Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DG-1907 Validate Channel Link #3736

Merged
merged 1 commit into from
Nov 25, 2024
Merged

DG-1907 Validate Channel Link #3736

merged 1 commit into from
Nov 25, 2024

Conversation

nikhilbonte21
Copy link

@nikhilbonte21 nikhilbonte21 commented Nov 13, 2024

Change description

We currently have frontend-only validation for the correct Slack link at the Persona “Add Link” CTA. However, the endpoint can insert a malicious link into the product.

We would want to have the same validation from the backend as well. Please check the linked security ticket for details.

Regex details - https://atlanhq.atlassian.net/browse/DG-1907?focusedCommentId=270252
Testing - https://atlanhq.atlassian.net/l/cp/Qm0GkvQR

Type of change

  • Bug fix (fixes an issue)
  • New feature (adds functionality)

Related issues

https://atlanhq.atlassian.net/browse/DG-1907

Checklists

Development

  • Lint rules pass locally
  • Application changes have been tested thoroughly
  • Automated tests covering modified code pass

Security

  • Security impact of change has been considered
  • Code follows company security practices and guidelines

Code review

  • Pull request has a descriptive title and context useful to a reviewer. Screenshots or screencasts are attached as necessary
  • "Ready for review" label attached and reviewers assigned
  • Changes have been reviewed by at least one other contributor
  • Pull request linked to task tracker where applicable

Copy link
Collaborator

@hr2904 hr2904 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Testcases LGTM, Code changes LGTM.

@nikhilbonte21 nikhilbonte21 merged commit d2a68b3 into master Nov 25, 2024
24 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants