DG-1924 | Update task vertex w impacted-vertices counts for remaining types of propagation #3897
Conversation
abhijeet-atlan
force-pushed
the
taskdg1924deleteprop
branch
from
ec5f7f1 to
3b3020c
Compare
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/DeleteHandlerV1.java
Outdated
Show resolved
Hide resolved
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphMapper.java
Outdated
Show resolved
Hide resolved
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/DeleteHandlerV1.java
Show resolved
Hide resolved
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphMapper.java
Outdated
Show resolved
Hide resolved
… types of propagation
abhijeet-atlan
force-pushed
the
taskdg1924deleteprop
branch
from
443d759 to
c095f36
Compare
| currentTask.setAssetsCountToPropagate((long) totalCount); | ||
|
|
||
| //update the 'assetsCountToPropagate' in the current task vertex. | ||
| AtlasVertex currentTaskVertex = (AtlasVertex) graph.query().has(TASK_GUID, currentTask.getGuid()).vertices().iterator().next(); |
There was a problem hiding this comment.
make this a method, instead of a single liner. As far as i remember, method already exists which can get taskVertex based on taskGuid
There was a problem hiding this comment.
getting the taskVertex gets from the POJO rather than inside the graph. This graph query is to make sure the change is persisted.
There was a problem hiding this comment.
Would still recommend creating a generic method in the mapper or helper file for this. This logic can be utilised in the future ofcourse. And yes in V2 ig you will be doing that.
| graph.commit(); | ||
|
|
||
| currentTask.setAssetsCountPropagated(currentTask.getAssetsCountPropagated() + totalCount); | ||
| currentTaskVertex.setProperty(TASK_ASSET_COUNT_PROPAGATED, currentTask.getAssetsCountPropagated()); |
There was a problem hiding this comment.
Why is line 3233->3237 not a single graph commit? and instead 2?
There was a problem hiding this comment.
the graph.commit(); is to commit the final count of all the tasks in the task vertex in the graph.
the next setter calls is to update the finished task count for the assetsCountPropagated
This specific method is responsible for the cleanup task propagation where the planner and executer are part of the same while loop, thats why the variables are updated after the task is finished rather than in real time.
The change required here is to split the planning and execution which will be done in the last versions of tag propagation.
for ref: check this and onward responses
| currentTask.setAssetsCountToPropagate((long) impactedVertices.size() - 1); | ||
|
|
||
| //update the 'assetsCountToPropagate' in the current task vertex. | ||
| AtlasVertex currentTaskVertex = (AtlasVertex) graph.query().has(TASK_GUID, currentTask.getGuid()).vertices().iterator().next(); |
There was a problem hiding this comment.
Change this one liner to a method call. As iterated previously in one of the comments
There was a problem hiding this comment.
for all the comments asking to make the graph call into a method instead of a one liner, me and janaki has discussed this and I will be doing that in version 2. Thats part of the code cleanup.
| currentTask.setAssetsCountToPropagate((long) verticesToRemove.size() + verticesToAddClassification.size() - 1); | ||
|
|
||
| //update the 'assetsCountToPropagate' in the current task vertex. | ||
| AtlasVertex currentTaskVertex = (AtlasVertex) graph.query().has(TASK_GUID, currentTask.getGuid()).vertices().iterator().next(); |
There was a problem hiding this comment.
for all the comments asking to make the graph call into a method instead of a one liner, me and janaki has discussed this and I will be doing that in version 2. Thats part of the code cleanup.
Change description
Type of change
Related issues
Checklists
Development
Security
Code review