Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scenario and Portfolio update #209

Merged
merged 3 commits into from
Mar 19, 2024

Conversation

DanteNiewenhuis
Copy link
Contributor

Summary

Updated Scenarios and Portfolios to be defined using JSON files.

Implementation Notes ⚒️

Scenarios and Portfolios are reworked and can now be defined using JSON files.
This makes it much easier for users to work without requiring in depth knowledge of the code.

External Dependencies 🍀

N/A

Breaking API Changes ⚠️

Removed capelin and greenifier experiments.
In their place a Scenario and Portfolio experiment is added.
These experiments show how a user can use the new implementations of Scenarios and Portfolios

Simply specify none (N/A) if not applicable.

…ios. Scenarios and Portfolios can now be defined using JSON files similar to topologies. This allows user to define experiments without changing any KotLin code.
@DanteNiewenhuis DanteNiewenhuis linked an issue Mar 19, 2024 that may be closed by this pull request
Copy link

codecov bot commented Mar 19, 2024

Codecov Report

Attention: Patch coverage is 6.01852% with 203 lines in your changes are missing coverage. Please review.

Project coverage is 71.02%. Comparing base (960b3d8) to head (f438432).

Files Patch % Lines
.../experiments/base/models/scenario/ScenarioSpecs.kt 0.00% 56 Missing ⚠️
...g/opendc/experiments/base/runner/ScenarioRunner.kt 0.00% 44 Missing ⚠️
...rg/opendc/experiments/scenario/ExamplePortfolio.kt 0.00% 19 Missing ⚠️
...eriments/base/models/scenario/ScenarioFactories.kt 0.00% 18 Missing ⚠️
...ndc/compute/service/scheduler/ComputeSchedulers.kt 0.00% 14 Missing ⚠️
...lin/org/opendc/experiments/scenario/ScenarioCli.kt 0.00% 12 Missing ⚠️
...pendc/experiments/base/models/scenario/Scenario.kt 0.00% 11 Missing ⚠️
...iments/base/models/portfolio/PortfolioFactories.kt 0.00% 6 Missing ⚠️
...periments/base/models/portfolio/PortfolioReader.kt 0.00% 6 Missing ⚠️
...experiments/base/models/scenario/ScenarioReader.kt 0.00% 6 Missing ⚠️
... and 5 more
Additional details and impacted files
@@             Coverage Diff              @@
##             master     #209      +/-   ##
============================================
- Coverage     71.08%   71.02%   -0.06%     
+ Complexity     2191     2158      -33     
============================================
  Files           355      352       -3     
  Lines          9966     9818     -148     
  Branches       1052     1058       +6     
============================================
- Hits           7084     6973     -111     
+ Misses         2556     2522      -34     
+ Partials        326      323       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@DanteNiewenhuis DanteNiewenhuis merged commit dff30fa into atlarge-research:master Mar 19, 2024
6 checks passed
@DanteNiewenhuis DanteNiewenhuis deleted the scenario branch March 21, 2024 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Expand Scenarios
2 participants