Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix start-swank/start-slime #3169

Merged
merged 5 commits into from
Nov 13, 2023
Merged

Fix start-swank/start-slime #3169

merged 5 commits into from
Nov 13, 2023

Conversation

aadcg
Copy link
Member

@aadcg aadcg commented Sep 15, 2023

Description

Closes #3153
Closes #3159

@jmercouris you can test connecting via slime by building the Flatpak from the git checkout.

@fosskers I'm not sure if you're able to test it, but I've tested with sly and it now works. Out of curiosity, how are getting Nyxt?

This PR has pre-requisites to be merged:

If these won't be accepted in time, I'll patch the flatpak so that the fix lands in the next release on Monday.

Please do NOT merge.

@aadcg aadcg changed the title Fix swank slime Fix start-swank/start-slime Sep 15, 2023
@aadcg aadcg requested a review from jmercouris September 21, 2023 21:08
@aadcg aadcg marked this pull request as ready for review September 21, 2023 21:09
@fosskers
Copy link

I was getting it as a prebuilt binary through Arch's package manager pacman. There is also a community-package version I could try that is based on the git master.

@jmercouris jmercouris marked this pull request as draft September 26, 2023 01:41
@aadcg
Copy link
Member Author

aadcg commented Sep 26, 2023

@fosskers You can send this patch without the line relative to slime to the Arch maintainers to fix start-slynk/swank. This is a temporary measure until this PR is merged.

@aadcg
Copy link
Member Author

aadcg commented Sep 26, 2023

Commands start-swank/slynk are now fixed on Flathub. On Guix, they have always worked. In short, these commands work on all official means of distribution.

This PR is dependent on the acceptance of some patches. Once merged, the commands will work on platforms that install Nyxt via the .tar that bundles the CL dependencies as git submodules.

@fosskers
Copy link

Thank you! No rush though, I can wait.

@aadcg aadcg mentioned this pull request Oct 9, 2023
@aadcg
Copy link
Member Author

aadcg commented Oct 9, 2023

Unfortunately, zero progress. Knocking the same doors, waiting for responses.

@aadcg
Copy link
Member Author

aadcg commented Oct 24, 2023

Waiting for the two patches sent to Guix to be accepted.

@aadcg
Copy link
Member Author

aadcg commented Nov 8, 2023

Waiting on https://debbugs.gnu.org/cgi/bugreport.cgi?bug=66722 to be merged.

@aadcg
Copy link
Member Author

aadcg commented Nov 12, 2023

The saga continues. I have now realized that yet another fix is needed. Waiting on slime/slime#797.

@aadcg
Copy link
Member Author

aadcg commented Nov 13, 2023

Waiting on https://debbugs.gnu.org/cgi/bugreport.cgi?bug=67146, but this PR can be merged before the patch is accepted by Guix.

For those using nyxt-make-guix-cl-for-nyxt, please temporarily comment the line swank/exts at nyxt.asd. That won't be needed anymore as soon as the patch mentioned above is accepted.

@aadcg aadcg marked this pull request as ready for review November 13, 2023 10:16
@aadcg aadcg removed the request for review from jmercouris November 13, 2023 10:17
@aadcg aadcg merged commit a6cc190 into master Nov 13, 2023
2 checks passed
@aadcg aadcg deleted the fix-swank-slime branch November 13, 2023 11:31
@aadcg
Copy link
Member Author

aadcg commented Nov 13, 2023

@fosskers the fix will land in the next Nyxt release. Please re-open #3153 in case you find issues.

@fosskers
Copy link

Thank you! I'll wait for the next release to be packaged by my distro and then reattempt the sly connections.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Can't connect to built-in Slynk from compiled Nyxt Commands start-swank and start-slynk are broken
2 participants