Review foreign interface #3290
Merged
Review foreign interface #3290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aadcg
force-pushed
the
review-foreign-interface
branch
2 times, most recently
from
964df41 to
d08c201
Compare
jmercouris
reviewed
Dec 20, 2023
jmercouris
reviewed
Dec 20, 2023
jmercouris
reviewed
Dec 20, 2023
jmercouris
approved these changes
Dec 20, 2023
Mistakenly introduced in 09042ac.
Highlights that renderer-specific objects inherit from T. Therefore, any specialization is more specific that the fallback method defined in this file.
Should have been in commit df5fc42.
Place the primary method after the around method to ease readability. Refactor docstring.
It doesn't need window as its argument, since prompt buffer objects have a window slot.
aadcg
force-pushed
the
review-foreign-interface
branch
from
d08c201 to
8af6b3c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A review of certain foreign interface quirks noticed while working on #2989.
Fixes #3265.
Won't be part of the 3-series.