Review system test logic #3291
Merged
Review system test logic #3291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ambrevar
reviewed
Dec 18, 2023
jmercouris
approved these changes
Dec 20, 2023
The previous implementation relied on the notion of a proper subpcakage. In the new implementation, a package is a subpackage of itself. From this results that, when checking for unbound exports or undocumented exports, the targeted package is checked too.
In order to run the test suite relative to the WebKitGTK port: (asdf:test-system :nyxt/gi-gtk)
So that testing the nyxt/gi-gtk system also runs the test suite from the nyxt system.
aadcg
force-pushed
the
review-system-test-logic
branch
from
454c5ba to
853ac43
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The scope issue pointed out in #3264 wasn't fully addressed. All offending undocumented symbols have been documented.
libraries/nasdf/compilation-tests.lispis a buggy linter. Besides #3264, it doesn't report the offense when deleting the docstring of a form define viadefine-command. Even if the implementation would be perfect, I am highly skeptical of the added value to the project. Developer discipline is what we need to aim for first and foremost. The discussion about the fate of this tool doesn't belong here regardless.Fixes #3264
I think it is beneficial to have a single invocation that triggers the complete test suite. I.e.,
(asdf:test-system :nyxt/gi-gtk)trigger the test suite ofnyxtandnyxt/gi-gtk, whereas (asdf:test-system :nyxt) behaves as before.Checklist:
Everything in this checklist is required for each PR. Please do not approve a PR that does not have all of these items.
cd /path/to/nyxt/checkout git submodule add https://gitlab.common-lisp.net/nyxt/py-configparser _build/py-configparser:documentations written in the aforementioned style. (It's OK to skip the docstring for really trivial parts.)changelog.lispwith my changes if it's anything user-facing (new features, important bug fix, compatibility breakage).migration.lispentry for all compatibility-breaking changes.(asdf:test-system :nyxt)and(asdf:test-system :nyxt/gi-gtk)) and they pass.