Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix 3373 #3378

Merged
merged 2 commits into from
Apr 4, 2024
Merged

Fix 3373 #3378

merged 2 commits into from
Apr 4, 2024

Conversation

aadcg
Copy link
Member

@aadcg aadcg commented Apr 4, 2024 •
edited
Loading

Description

Fixes #3376

Checklist:

  • Git branch state is mergable.
  • Changelog is up to date (via a separate commit).
  • New dependencies are accounted for.
  • Documentation is up to date.
  • Compilation and tests ((asdf:test-system :nyxt/<renderer>))
    • No new compilation warnings.
    • Tests are sufficient.

aadcg added 2 commits April 4, 2024 16:28
@aadcg
spinneret-tags: Refactor nselect.
2814013 
A partial refactor of commit 5d18d0a that
introduced a bug (see issue below).

The copy-p keyword argument is recovered since it adds flexibility without extra
complexity costs.

Closes #3376.
@aadcg
changelog: Mention common-settings crash fix.
c531b3c
@aadcg aadcg merged commit c531b3c into master Apr 4, 2024
3 checks passed
@aadcg aadcg deleted the fix-3373 branch April 4, 2024 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Failed to load URL nyxt:common-settings?section=%1Btheme-and-style
1 participant
@aadcg