fix: double dispose (#68)

* fix: double dispose * fix(sec): bump Caching.Memory
atmina · Oct 22, 2024 · 00f2967 · 00f2967
1 parent 2d85ca2
commit 00f2967
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 4 deletions.
diff --git a/src/Fluss.Regen/Fluss.Regen.csproj b/src/Fluss.Regen/Fluss.Regen.csproj
@@ -29,7 +29,7 @@
         </PackageReference>
         <PackageReference Include="Microsoft.CodeAnalysis.CSharp" Version="4.10.0" />
         <PackageReference Include="Microsoft.CodeAnalysis.CSharp.Workspaces" Version="4.10.0" />
-        <PackageReference Include="Microsoft.Extensions.Caching.Memory" Version="8.0.0" />
+        <PackageReference Include="Microsoft.Extensions.Caching.Memory" Version="8.0.1" />
     </ItemGroup>
 
     <ItemGroup>

diff --git a/src/Fluss/Fluss.csproj b/src/Fluss/Fluss.csproj
@@ -15,7 +15,7 @@
 
     <ItemGroup>
         <PackageReference Include="Collections.Pooled" Version="1.0.82" />
-        <PackageReference Include="Microsoft.Extensions.Caching.Memory" Version="8.0.0" />
+        <PackageReference Include="Microsoft.Extensions.Caching.Memory" Version="8.0.1" />
         <PackageReference Include="Microsoft.Extensions.DependencyInjection" Version="8.0.0" />
         <PackageReference Include="Microsoft.Extensions.Hosting.Abstractions" Version="8.0.0" />
         <PackageReference Include="Microsoft.Extensions.Logging" Version="8.0.0" />

diff --git a/src/Fluss/UnitOfWork/UnitOfWorkFactory.cs b/src/Fluss/UnitOfWork/UnitOfWorkFactory.cs
@@ -23,7 +23,8 @@ public async ValueTask Commit(Func<IWriteUnitOfWork, ValueTask> action)
         await RetryPolicy
             .ExecuteAsync(async () =>
             {
-                using var unitOfWork = serviceProvider.GetRequiredService<UnitOfWork>();
+                using var scope = serviceProvider.CreateScope();
+                var unitOfWork = scope.ServiceProvider.GetRequiredService<UnitOfWork>();
                 await action(unitOfWork);
                 await unitOfWork.CommitInternal();
             });
@@ -36,7 +37,8 @@ public async ValueTask<T> Commit<T>(Func<IWriteUnitOfWork, ValueTask<T>> action)
         return await RetryPolicy
             .ExecuteAsync(async () =>
             {
-                using var unitOfWork = serviceProvider.GetRequiredService<UnitOfWork>();
+                using var scope = serviceProvider.CreateScope();
+                var unitOfWork = scope.ServiceProvider.GetRequiredService<UnitOfWork>();
                 var result = await action(unitOfWork);
                 await unitOfWork.CommitInternal();
                 return result;