Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: $discriminate with runtime check (v2.0.0) #9

Merged
merged 12 commits into from
Feb 21, 2024
Merged

Conversation

reiv
Copy link
Member

@reiv reiv commented Feb 20, 2024

Bumping to 2.0.0 since this includes a breaking change.

  • improved $discriminate with runtime check
  • fields prefixed with __ now surface in FormBuilder (they were previously ignored)

Includes some housekeeping:

  • use @atmina/linting
  • replace microbundle with tsup
  • address package vulnerabilities reported by dependabot

Julian Schleemann added 11 commits February 20, 2024 17:25
fix: $discriminate type

BREAKING CHANGE: `$discriminate` now returns the discriminator and a
narrowed FormBuilder.
- Use tsup instead of the currently unmaintained microbundle
- Fix version conflict in the React types
- Address vulnerabilities in dependencies reported by Dependabot
@reiv reiv requested a review from mvarendorff2 February 21, 2024 09:24
.github/workflows/build.yml Outdated Show resolved Hide resolved
src/formbuilder.tsx Show resolved Hide resolved
@reiv reiv requested a review from mvarendorff2 February 21, 2024 13:12
Copy link
Member

@mvarendorff2 mvarendorff2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mvarendorff2 mvarendorff2 merged commit 77e0241 into main Feb 21, 2024
4 checks passed
@mvarendorff2 mvarendorff2 deleted the discriminatev2 branch February 21, 2024 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants