Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wrapped command if not full year - fix issue #2507 #2557

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

hetoug
Copy link

@hetoug hetoug commented Jan 21, 2025

If atuin has not been used the whole year, then the "Command Evolution" will be misleading, as the year is split 182 days after the first command.

This change set the mid-point of the year mid-ways between the first and last command in the year.

Checks

  • I am happy for maintainers to push small adjustments to this PR, to speed up the review cycle
  • I have checked that there are no existing pull requests for the same thing

If atuin has not been used the whole year, then the "Command Evolution"
will be misleading, as the year is split 182 days after the first command.

This change set the mid-point of the year midways between the first and
last command in the year.
@tessus
Copy link
Contributor

tessus commented Jan 21, 2025

The problem is that it is still wrong.

in the first half of 2024 means January to June (incl). But if you started to use atuin in July, it will show the commands from July to September (incl) in the first half of the year.

@hetoug
Copy link
Author

hetoug commented Jan 22, 2025

It is better than it is now! Where the second half of the year is 6 months after you started.
in the first half of 2024 could be construed to mean the first half of your usage in 2024 -. but probably not.

I couldn't find a short and correct text, so I left it as it was.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants