Chore: update clippy to toolchain 1.84 rules #986
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrLSD
changed the title
aleksuss
approved these changes
Jan 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
🛋️ PR updates clippy rules to
rutst toolchain 1.84. But rust itself still:1.81.0. The only reason isnear-vm-runner. Also we can't update ronear-vm-runner 0.28as tests fail with a deserialization error.Changes
➡️ Updated
⚠️ clippy
clippyrequirements torust toolchain 1.84➡️ Rust toolchain not changed. It's related to
near-vm runner v0.27- it doesn't support a higher Rust version.➡️
near-vm-runnerwas not updated tov0.28as it's still not supported evenrust 1.83(it was tested for aurora-engine toolchains:1.83,1.84)div_ceilwas enabled, asEngineused own customdivimplementation. When was startedengine testswithdiv_ceilit happened to have a gas overflow.