Add unit test for XKCD 3038 alt-text #377
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See for context: <https://xkcd.com/3038/>. Presumably, the joke only works if the speed limit in question corresponds to a realistic speed limit for American roads, so we take the range to be from 25 MPH (many residential streets) to 75 MPH (some roads in places I have seen such as parts of MI or TX). To make this work, it was convenient to add unit definitions for `Arcminutes` and `Arcseconds`. These have various choices for unit symbol, but I decided to go with `am` and `as` because this will be the most consistent with users who form symbols for `mas` and `uas`. For the labels, in any case, I went with `'` and `"`. I could be persuaded to go with `''` for arcseconds, but I think `"` is likely to be better overall. We also now group all of our XKCD test cases into an `Xkcd` test family, because of course we do.
chiphogg
added
the
release notes: 📏 lib (new units/constants)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See for context: https://xkcd.com/3038/. Presumably, the joke only
works if the speed limit in question corresponds to a realistic speed
limit for American roads, so we take the range to be from 25 MPH (many
residential streets) to 75 MPH (some roads in places I have seen such as
parts of MI or TX).
To make this work, it was convenient to add unit definitions for
ArcminutesandArcseconds. These have various choices for unitsymbol, but I decided to go with
amandasbecause this will be themost consistent with users who form symbols for
masanduas.For the labels, in any case, I went with
'and". I could bepersuaded to go with
''for arcseconds, but I think"is likely tobe better overall.
We also now group all of our XKCD test cases into an
Xkcdtest family,because of course we do.