Fix multi-namespace watches and add a test #339
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josephschorr
reviewed
Nov 8, 2024
|
|
||
| func localClusterNamespace(ns string) string { | ||
| if ns == "" { | ||
| return "local" |
There was a problem hiding this comment.
it's just a part of the key used to locate the right cache. I use "local" as a convention because it's part of the same cluster the controller is running on, and controllers can also start watches of remote clusters.
| } | ||
| for _, cluster := range clusters { | ||
| c.enqueue(v1alpha1ClusterGVR, cluster) | ||
| for _, ns := range c.namespaces { |
There was a problem hiding this comment.
if the namespace list is empty, where does it get watched then?
There was a problem hiding this comment.
namespaces gets defaulted to []string{corev1.AllNamespace} (which is just the empty string) if it is empty on startup.
the existing implementation didn't wire up the caches correctly. this also adds a test of the namespace watch modes.
tstirrat15
approved these changes
Nov 12, 2024
There was a problem hiding this comment.
I had @ecordell walk me through this one and it looks good from my perspective
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existing implementation didn't wire up the caches correctly if more than one namespace was specified. Caches are identified by the namespace they watch, so we need to construct lookup keys per-watched namespace.
This also adds a test of the namespace watch modes.