[mysql] pipe logger into mysql for debug printing (#1055) #2217
+13
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
|
I have read the CLA Document and I hereby sign the CLA |
|
recheck |
authzedbot
added a commit
to authzed/cla
that referenced
this pull request
Jan 29, 2025
ecordell
reviewed
Jan 29, 2025
tstirrat15
previously approved these changes
Jan 29, 2025
Comment on lines
-42
to
-49
|
|
||
| func Print(v ...interface{}) { | ||
| Logger.Debug().CallerSkipFrame(1).Msg(fmt.Sprint(v...)) | ||
| } | ||
|
|
||
| func Printf(format string, v ...interface{}) { | ||
| Logger.Debug().CallerSkipFrame(1).Msgf(format, v...) | ||
| } |
There was a problem hiding this comment.
I take it these are otherwise unused?
Comment on lines
676
to
680
| type debugLogger struct{} | ||
|
|
||
| func (debugLogger) Print(v ...any) { | ||
| log.Logger.Debug().CallerSkipFrame(1).Msg(fmt.Sprint(v...)) | ||
| } |
There was a problem hiding this comment.
Is this specific to MySQL? Is it worth extending to the other datastores as well? It's also okay if that's outside of the scope of this PR.
There was a problem hiding this comment.
every datastore seems to have its own interface -- this particular one is specific to mysql, alas....
barakmich
force-pushed
the
mysql_logging
branch
from
1637f0b to
fa5e56e
Compare
ecordell
approved these changes
Jan 29, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Renames some variables for clarity, remove unused logging functions and add MySQL debug printing support.