Add a metric tracking the selected replica #2231
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area/datastore
vroldanbet
reviewed
Feb 5, 2025
| if err != nil { | ||
| return "", errors.New("could not parse datastore URL") | ||
| } | ||
| return u.Host + u.Path, nil |
There was a problem hiding this comment.
note that returning host+path will lead to explosion of cardinality when having many spiced clusters in the same physical database. I do see the value in disambiguating telemetry across spicedb clusters, just something to note.
| @@ -100,6 +100,10 @@ type snapshot struct { | |||
| db *memdb.MemDB | |||
| } | |||
|
|
|||
| func (mdb *memdbDatastore) MetricsID() (string, error) { | |||
| return "memdb-" + mdb.uniqueID, nil | |||
There was a problem hiding this comment.
this almost certainly cause explosion in cadinality for these metrics. E.g. when MemDB SpiceDB is embedded in another process, each restart will bring different uniqueID. I'd personally just have it as memdb - the scenario of multiple SpiceDB processes in memory is less likely, and the explosion in cardinality can have severe cost implications
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows for understanding which replica(s) are being used