Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pci_devices: fix test name #1558

Merged
merged 1 commit into from
Dec 5, 2018

Conversation

rayx
Copy link
Contributor

@rayx rayx commented Nov 13, 2018

Signed-off-by: Huan Xiong [email protected]

Signed-off-by: Huan Xiong <[email protected]>
@rayx
Copy link
Contributor Author

rayx commented Nov 13, 2018

A bit off-topic... I actually don't quite understand why the test author wanted to test the configurations defined in pci_devices.cfg. Many configurations are about connecting a PCIE switch to a PCIE-to-PCI bridge. Is this a typical scenario? Why would someone want to do this? On the other hand, the test doesn't even cover a configuration like root->switch->devices, which I think is a basic and typical configuration that should be tested.

@vivianQizhu
Copy link
Contributor

Right, as I mentioned in #1557, this test is out of date, that's an old configuration used to exist. I am working on adding pcie-pci-bridge, hopefully post it this week. Thanks.

@rayx
Copy link
Contributor Author

rayx commented Nov 13, 2018

It's good to know that. I'll just skip those "root->bridge->switch->..." configurations (they failed on my system). Thanks.

Copy link
Contributor

@vivianQizhu vivianQizhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sense for me.

@vivianQizhu
Copy link
Contributor

@ybduan Request for your ack.

@ybduan
Copy link
Contributor

ybduan commented Nov 13, 2018

Acked-by: Yanbin Duan [email protected]

Name changing doesn't interfere with functionality, but considering it's about q35, needs ACK from @jingzhao84

@jingzhao84
Copy link
Contributor

ok for name changing
acked-by: [email protected]

@vivianQizhu
Copy link
Contributor

Thanks all.

@vivianQizhu vivianQizhu merged commit 9fd1e11 into autotest:master Dec 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants