chore(core/types): Block libevm Body and RLP hooks
#750
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darioush
reviewed
Jan 16, 2025
darioush
reviewed
Jan 16, 2025
darioush
reviewed
Jan 16, 2025
qdm12
commented
Jan 17, 2025
Comment on lines
+22
to
+26
|
|
||
| // Fields removed from geth: | ||
| // - withdrawals Withdrawals | ||
| // - ReceivedAt time.Time | ||
| // - ReceivedFrom interface{} |
There was a problem hiding this comment.
note to self: remove these eventually
Comment on lines
+143
to
+145
| func WrapWithTimestamp(b *Block) *BlockWithTimestamp { | ||
| return &BlockWithTimestamp{Block: b} | ||
| } | ||
|
|
||
| type BlockWithTimestamp struct { | ||
| *Block | ||
| } | ||
|
|
||
| func (b *BlockWithTimestamp) Timestamp() uint64 { | ||
| return b.Time() |
There was a problem hiding this comment.
remove this once #749 is merged
qdm12
force-pushed
the
qdm12/core/types/block-libevm
branch
7 times, most recently
from
2e8acfd to
c068eea
Compare
2 tasks
qdm12
force-pushed
the
qdm12/core/types/block-libevm
branch
from
c068eea to
a3593f6
Compare
qdm12
changed the base branch from
libevm-upstream-types
to
qdm12/core/types/body-libevm
qdm12
changed the title
Block libevm Body and RLP hooks
qdm12
force-pushed
the
qdm12/core/types/body-libevm
branch
2 times, most recently
from
53eb228 to
d65a0d2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
How this works
Based on #760
➡️ Libevm block codec+body hooks PR
How this was tested
Need to be documented?
Need to update RELEASES.md?