Add proof verification test #359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richardpringle
force-pushed
the
more-tests
branch
from
89ef569 to
978629b
Compare
richardpringle
commented
Nov 20, 2023
| _ => return Ok(value_node.into()), | ||
| }; | ||
|
|
||
| Ok(value) |
There was a problem hiding this comment.
There are currently tests that only pass by chance of leaf-nodes not containing paths. This assures that those will always pass
richardpringle
commented
Nov 20, 2023
| let value = match NodeType::decode(&value_node) { | ||
| Ok(NodeType::Branch(branch)) => branch.value().as_ref().map(|v| v.to_vec()), | ||
| Ok(NodeType::Leaf(leaf)) => leaf.data().to_vec().into(), | ||
| _ => return Ok(value_node.into()), |
There was a problem hiding this comment.
Weird case with extension nodes here... This will go away when extension nodes go away
rkuris
approved these changes
Nov 20, 2023
richardpringle
force-pushed
the
more-tests
branch
from
978629b to
dfdde29
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a simple proof verification test