Use more strict types in node-(de)serialization #372
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richardpringle
commented
Nov 22, 2023
| root_hash: [u8; TRIE_HASH_LEN], | ||
| attrs: NodeAttributes, | ||
| is_encoded_longer_than_hash_len: Option<bool>, | ||
| } |
There was a problem hiding this comment.
This is 100% stack-based and can actually be (de)serialized in one shot. I didn't do that here though, that can be done later if necessary.
richardpringle
commented
Nov 22, 2023
| @@ -368,45 +369,55 @@ impl Storable for Node { | |||
| match meta_raw.as_deref()[TRIE_HASH_LEN + 1].try_into()? { | |||
| NodeTypeId::Branch => { | |||
| // TODO: add path | |||
| // TODO: figure out what this size is? | |||
There was a problem hiding this comment.
I figure it out later, I promise.
richardpringle
force-pushed
the
use-an-enum-in-leaf-node-storable
branch
from
743cf84 to
267c95d
Compare
richardpringle
force-pushed
the
refactor-node-serialization
branch
from
4232be2 to
d1650bd
Compare
richardpringle
force-pushed
the
use-an-enum-in-leaf-node-storable
branch
from
267c95d to
ab20071
Compare
richardpringle
force-pushed
the
refactor-node-serialization
branch
from
d1650bd to
fd6e3b1
Compare
xinifinity
approved these changes
Nov 22, 2023
(for storage, not encoding)
richardpringle
force-pushed
the
refactor-node-serialization
branch
from
fd6e3b1 to
49a0e8a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use more strict types in node (de)serialization for storage. Strict type conversions eliminate some potential bugs in logic at compile-time.
This is the precursor to a more major refactor, moving storage (de)serialization implementations into the individual node-types.