Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update ANYRUN.py #1

Open
wants to merge 5,843 commits into
base: master
Choose a base branch
from
Open

Update ANYRUN.py #1

wants to merge 5,843 commits into from

Conversation

mincrodo
Copy link

Status

Ready/In Progress/In Hold(Reason for hold)

Related Issues

fixes: link to the issue

Description

A few sentences describing the overall goals of the pull request's commits.

Screenshots

Paste here any images that will help the reviewer

Related PRs

List related PRs against other branches:

branch PR

Required version of Demisto

x.x.x

Does it break backward compatibility?

  • Yes
    • Further details:
  • No

Must have

  • Tests
  • Documentation (with link to it)
  • Code Review

Dependencies

Mention the dependencies of the entity you changed as given from the precommit hooks in checkboxes, and tick after tested them.

  • Dependency 1
  • Dependency 2
  • Dependency 3

Additional changes

Describe additional changes done, for example adding a function to common server.

orlichter1 and others added 30 commits August 19, 2019 14:56
@orlichter1
Merge remote-tracking branch 'origin/Splunkpy-fetch-limit' into Splun…
0e63880 
…kpy-fetch-limit
finished playbook, updated args in list entities
18fc68b
fixed the user msg in dict_value_to_integer
aa2909c
@bakatzir
Pan-OS - full logs UC (demisto#4099)
408d998 
* panorama-logs all types 1st commit

* catch query time out for a job id

* add outputs, deprecate old traffic commands, add unit tests

* update RN

* update desc

* update desc2

* added pb, test pb, url addition of '/' according to pan-os convention

* handle issue when we have exactly 1 log retrieved

* desc

* Updated deprecated command descriptions and new commands.

* Updated descriptions.

* Updated task names and descriptions.

* Updated RN description.
@ShahafBenYakir
Merge pull request demisto#4134 from demisto/build_shift
fde4035 
Skipped CheckpointFW-test: Test is not stable (Issue 18643)
@DeanArbel
Changed new layouts to system: true (demisto#4132)
0ee8b46 
* changed new layouts to system: true

* removed system:true
@bakatzir
ThinkstCanary - handle error msg with grace (demisto#4035)
e767a1c 
* handle error msg with grace

* yuval cr101

* exception handling 102

* rn new format

* error handling and printing

* rn edit
@orlichter1
changelog
fbb312f
@ShahafBenYakir
Create slack message function
3b9acf2 
Added message to point on build
@ShahafBenYakir
Create slack message function
266b405 
Added message to point on build
Added ZeroFox integrarion description
8c47dfe
@DeanArbel
Indicator Layouts cherry pick (demisto#4144)
ad565d2 
* commited first 24

* commited remaining 9

* removed system: false fields

* Update layout-indicatorsDetails-Account_CHANGELOG.md
@teizenman @ronykoz
Have i been pwned v3 (demisto#4070)
9341116 
* Initial re-write from JS to Python

* Initial re-write from JS to Python + new playbook

* Post PR

* Post PR changes

* Post PR changes

* Added pastes to email query, updated test-playbook accordingly

* Added pastes to email query, updated test-playbook accordingly

* updating per my own review

* fixing context paths

* fixing context paths

* Updated descriptions.

* naming fixes

* context paths adjustment
cherry pick
46fd310
@DeanArbel
removed required from schema (demisto#4150)
ef15216
@DeanArbel
removed required from schema (demisto#4149)
5344820
@ShahafBenYakir
Added server url to slack message
76b2763
@ShahafBenYakir
Trying to set the slack message as MD
1a5005d
Merge pull request demisto#4152 from demisto/have-i-been-pwned-v2
96ce73e 
cherry pick
@ShahafBenYakir
Added condition to slack messages be sent only on nightly
00f1f36
fixed:
fc1acf8 
Failed: Integrations/ZeroFox/ZeroFox.yml failed
<SchemaError: error code 2: Schema validation failed:
 - Key 'longRunningPort' was not defined. Path: '/script'.
 - Key 'longRunning' was not defined. Path: '/script'.: Path: '/'>
fixed indentation in lines 540-545 in ZeroFox.py
09b0b1d
fixed indentation in lines 540-545 in ZeroFox.py
cca4a04
@ShahafBenYakir
Added condition to slack messages be sent only on nightly
c892a34
fixed mypy errors
d1838bd
@ShahafBenYakir
Replaced is_nightly with options.nightly
e7222f0
fixed mypy errors
9074fa8
@ShahafBenYakir
Skipped CarbonBlackLiveResponseTest
0164337
@ShahafBenYakir
Increased Extract Indicators From File - Generic v2 - Test timeout to…
18ea81c 
… 5 min
@DeanArbel
fixed id of indicator fields (demisto#4154)
6f16fc9
@avidan-H avidan-H requested review from avidan-H and removed request for avidan-H August 29, 2019 12:58
@avidan-H avidan-H requested review from avidan-H and removed request for avidan-H August 29, 2019 13:13
@avidan-H avidan-H self-requested a review August 29, 2019 13:20
@avidan-H avidan-H removed their request for review September 1, 2019 08:46
@avidan-H
Copy link
Owner

avidan-H commented Sep 1, 2019

Thank you for your contribution. Your generosity and caring are unrivaled! Rest assured - our content wizard @avidan-H will very shortly look over your proposed changes.

@avidan-H avidan-H self-requested a review September 1, 2019 08:49
@avidan-H
Copy link
Owner

avidan-H commented Sep 1, 2019

Hey @mincrodo, it appears you made changes to Integrations/ANYRUN/ANYRUN.py. It is very likely that the reviewer will want you to add a unittest for your code changes in the Integrations/ANYRUN/ANYRUN_test.py file - please refer to the documentation https://github.com/demisto/content/tree/master/docs/tests/unit-testing for more details. Because of your changes you will also need to update the Integrations/ANYRUN/CHANGELOG.md file - please refer to the documentation https://github.com/demisto/content/tree/master/docs/release_notes for more details.

@avidan-H
Copy link
Owner

avidan-H commented Sep 1, 2019

@avidan-H This PR won't review itself and I'm not going to do it for you (I bet you'd like that wouldn't you) - look it over, eh?

@avidan-H
Copy link
Owner

avidan-H commented Sep 1, 2019

"And some things that should not have been forgotten were lost. History became legend. Legend became myth. And for two and a half thousand years", @avidan-H had not looked at this beautiful PR - as they were meant to do.

@avidan-H
Copy link
Owner

avidan-H commented Sep 1, 2019

These reminders don't seem to be working and the issue is getting pretty stale - @avidan-H - consider whether this PR is still relevant or should be closed.

@avidan-H
Copy link
Owner

avidan-H commented Sep 1, 2019

@avidan-H This PR won't review itself and I'm not going to do it for you (I bet you'd like that wouldn't you) - look it over, eh?

@avidan-H
Copy link
Owner

avidan-H commented Sep 1, 2019

@avidan-H This PR won't review itself and I'm not going to do it for you (I bet you'd like that wouldn't you) - look it over, eh?

@avidan-H
Copy link
Owner

avidan-H commented Sep 1, 2019

"And some things that should not have been forgotten were lost. History became legend. Legend became myth. And for two and a half thousand years", @avidan-H had not looked at this beautiful PR - as they were meant to do.

@avidan-H
Copy link
Owner

avidan-H commented Sep 1, 2019

These reminders don't seem to be working and the issue is getting pretty stale - @avidan-H - consider whether this PR is still relevant or should be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@avidan-H avidan-H Awaiting requested review from avidan-H

Assignees
No one assigned
Labels
Contribution HAHA Test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.