fix: search_controller null error

[Paul-Bob]

Description

Fixes the JS search controller.

.aa-DetachedOverlay is already getting removed when a value is selected from the search list, there is no need to remove it with code.

Fixes:

search_controller.js:223 Uncaught (in promise) TypeError: Cannot read properties of null (reading 'remove')
    at n.handleOnSelect (search_controller.js:223:51)

Checklist:

• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• I have added tests that prove my fix is effective or that my feature works

[codeclimate]

Code Climate has analyzed commit 21ac470 and detected 0 issues on this pull request.

View more on Code Climate.

[thiagovsk]

👏

[priscilaformaggio]

👏

[github-actions]

This PR has been merged into main. The functionality will be available in the next release.

Please check the release guide for more information.