Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: standalone action disabled and enabled classes #3520

Merged
merged 4 commits into from
Dec 13, 2024

Conversation

Paul-Bob
Copy link
Contributor

@Paul-Bob Paul-Bob commented Dec 12, 2024

Description

Fixes #3395

Adjust opacity for disabled actions and resolve an issue where row actions became disabled after toggling the selection of a record.

disabled_actions.mp4

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

@github-actions github-actions bot added the Fix label Dec 12, 2024
Copy link

codeclimate bot commented Dec 12, 2024

Code Climate has analyzed commit dbf377b and detected 0 issues on this pull request.

View more on Code Climate.

@Paul-Bob Paul-Bob changed the title Fix/standalone action disabled and enabled classes fix: standalone action disabled and enabled classes Dec 12, 2024
@Paul-Bob Paul-Bob merged commit 5a8f449 into main Dec 13, 2024
21 checks passed
@Paul-Bob Paul-Bob deleted the fix/standalone_action_disabled_and_enabled_classes branch December 13, 2024 14:17
Copy link
Contributor

This PR has been merged into main. The functionality will be available in the next release.

Please check the release guide for more information.

@pjmuller
Copy link

Hi @Paul-Bob thanks for shipping this,

  1. I guess it's not in 3.15.3 yet right? Can you add it in 3.15.4, our customers are getting confused and asking questions about this...

  2. when we spoke about this you said I would need to specify specific css classes for inactive. Is this still the case
    the code suggests that you implemented it in a generic way I guess ? disabled:opacity-60 data-[disabled='true']:opacity-60 (which is perfect to me) just want to know how to use it when it ships ;)

@Paul-Bob
Copy link
Contributor Author

Paul-Bob commented Dec 17, 2024

Hi @pjmuller this will be included on 3.15.4 which we're releasing during this week.

when we spoke about this you said I would need to specify specific css classes for inactive. Is this still the case
the code suggests that you implemented it in a generic way I guess ? disabled:opacity-60 data-[disabled='true']:opacity-60 (which is perfect to me) just want to know how to use it when it ships ;)

Yes, we opted for a more generic implementation using opacity, I mentioned it here. No action is required on your part during the update; it will be applied automatically.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

non standalone actions on custom controls
2 participants