Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Change associations controller path to avoid naming collisions #3529

Closed
wants to merge 2 commits into from

Conversation

aburgel
Copy link

@aburgel aburgel commented Dec 15, 2024

Description

Fixes #3525

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

Manual review steps

  1. Use repo app from has_many field named actions causes exception #3525 with this branch to show that exception no longer occurs.

Manual reviewer: please leave a comment with output from the test if that's the case.

Copy link

codeclimate bot commented Dec 15, 2024

Code Climate has analyzed commit 06aeecb and detected 0 issues on this pull request.

View more on Code Climate.

@Paul-Bob
Copy link
Contributor

Thanks for looking into this, @aburgel. Since the issue that originated this has a simple workaround, I'm closing this PR, and we'll hold off on this refactor for now. We might revisit it in the future.

@Paul-Bob Paul-Bob closed this Dec 18, 2024
@aburgel
Copy link
Author

aburgel commented Dec 18, 2024

@Paul-Bob No worries. Thanks for helping with the workaround.

My team is just starting out with Avo (and paying for Pro) and we generally like to contribute fixes if we can. So it would be helpful to know the best way to help with PRs. Is your concern with this PR more about backward compatibility? Or is it something else?

@Paul-Bob
Copy link
Contributor

My team is just starting out with Avo (and paying for Pro) and we generally like to contribute fixes if we can.

That's awesome! We truly value and appreciate contributions from the community.

So it would be helpful to know the best way to help with PRs.

Normally we discuss the proposed approach and overall direction on the issue thread before diving into the work. However we're absolutely open to direct PRs for more straightforward fixes.

Is your concern with this PR more about backward compatibility?

Thank you for asking! Yes, backward compatibility is one of my primary concerns here. This change would introduce a breaking change for users who currently rely on direct links to certain association pages.

Another consideration is that while this addresses your edge case, the Action model and other cases mentioned in the issue still cannot be created due to conflicts with internal controllers.

There is some work to do around routing and we might get back to this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

has_many field named actions causes exception
2 participants