Add direct image upload to the EasyMDE field #3597
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
| }/${encodeURIComponent(blob.filename)}`; | ||
| } | ||
|
|
||
| get toolbarItems() { |
There was a problem hiding this comment.
Function toolbarItems has 32 lines of code (exceeds 25 allowed). Consider refactoring.
|
Code Climate has analyzed commit 94ad7fe and detected 0 issues on this pull request. View more on Code Climate. |
|
|
||
| export default class extends Controller { | ||
| static targets = ['element'] | ||
| static targets = ["element"]; |
There was a problem hiding this comment.
This seems unrelated
| } | ||
| } | ||
|
|
||
| _configureImageUploads(options) { |
There was a problem hiding this comment.
Let's use the JS private notiation please.
Suggested change
| _configureImageUploads(options) { | |
| #configureImageUploads(options) { |
Then can be used liek so this.#configureImageUploads()
adrianthedev
requested changes
Jan 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a configurable image upload feature for the EasyMDE field.
It works by using the own editor's upload feature that receives a URL for an uploaded file and inserts it into the document.
Checklist:
Screenshots & recording
easy-mde-flow.mp4
Manual review steps
The only change needed for this feature to work is to add the
image_upload: trueflag to amarkdownfield.In my case, I added it to the projects in the Avo demo app:
field :description, as: :markdown, height: "350px", image_upload: true