Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: grid view item selector #3613

Merged
merged 2 commits into from
Jan 27, 2025
Merged

fix: grid view item selector #3613

merged 2 commits into from
Jan 27, 2025

Conversation

Paul-Bob
Copy link
Contributor

Description

Fixes #3591

Fixes an issue where non-standalone actions were not being enabled or disabled after selecting or deselecting records in grid view.

This issue originated from two lines of JavaScript that attempted to add and remove a class to the closest <tr> element without verifying its existence. However, in grid view, no <tr> elements are present.

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

@github-actions github-actions bot added the Fix label Jan 27, 2025
@Paul-Bob Paul-Bob self-assigned this Jan 27, 2025
Copy link

codeclimate bot commented Jan 27, 2025

Code Climate has analyzed commit 7111af7 and detected 0 issues on this pull request.

View more on Code Climate.

@Paul-Bob Paul-Bob merged commit 026da08 into main Jan 27, 2025
20 checks passed
@Paul-Bob Paul-Bob deleted the fix/grid_view_item_selector branch January 27, 2025 11:54
Copy link
Contributor

This PR has been merged into main. The functionality will be available in the next release.

Please check the release guide for more information.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bulk actions remain inactive when items are selected in gallery mode only
1 participant