Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enhancement: add saveButton stimulus target to save button #3620

Merged
merged 1 commit into from
Jan 30, 2025
Merged

enhancement: add saveButton stimulus target to save button #3620

merged 1 commit into from
Jan 30, 2025

Conversation

Paul-Bob
Copy link
Contributor

Description

Fixes #3607

Adding the saveButton target to all the stimulus controllers registered on a resource.

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

@Paul-Bob Paul-Bob added the Enhancement Not necessarily a feature, but something has improved label Jan 30, 2025
@Paul-Bob Paul-Bob requested a review from adrianthedev January 30, 2025 12:06
@Paul-Bob Paul-Bob self-assigned this Jan 30, 2025
@codeclimate CodeClimate
Copy link

codeclimate bot commented Jan 30, 2025

Code Climate has analyzed commit 23e6181 and detected 0 issues on this pull request.

View more on Code Climate.

adrianthedev
adrianthedev approved these changes Jan 30, 2025
View reviewed changes
Copy link
Collaborator

@adrianthedev adrianthedev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Haven't manually tested it.

@Paul-Bob Paul-Bob changed the title enhancement: add target to save button enhancement: add saveButton stimulus target to save button Jan 30, 2025
@Paul-Bob Paul-Bob merged commit ba6578f into main Jan 30, 2025
21 checks passed
@Paul-Bob Paul-Bob deleted the enhancement/add_target_to_save_button branch January 30, 2025 12:21
@github-actions GitHub Actions
Copy link
Contributor

This PR has been merged into main. The functionality will be available in the next release.

Please check the release guide for more information.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adrianthedev adrianthedev adrianthedev approved these changes

Assignees

@Paul-Bob Paul-Bob

Labels
Enhancement Not necessarily a feature, but something has improved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Custom stimulus controller and exposed target on resource form submit button
2 participants
@Paul-Bob @adrianthedev