-
-
Notifications
You must be signed in to change notification settings - Fork 271
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enhancement: Detect polymorphic associations in generator #3645
Open
Nevelito
wants to merge
36
commits into
avo-hq:main
Choose a base branch
from
Nevelito:detect_associations
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+65
−5
Open
Changes from 1 commit
Commits
Show all changes
36 commits
Select commit
Hold shift + click to select a range
167a173
Chceck potential polymorphic association
Nevelito c238a19
Fix issues in recource generator
Nevelito 7f13454
Change generator option
Nevelito 4c50d1e
small changes
Nevelito 87126a8
few changes
Nevelito 4c2a88a
Merge branch 'main' into detect_associations
Nevelito b0c824f
fix some rubocop request changes
Nevelito d82593c
next changes
Nevelito b3ea027
request changes
Nevelito a61cf12
Change generator
Nevelito d370bc2
Next attempt to fix finding polymorphic associations
Nevelito 15c97fb
fix standardrb
Nevelito 33ba42d
small changes
Nevelito 6da8b54
delete debugger
Nevelito 7fd71a3
change order in generate_fields
Nevelito 71edde5
optymalize code
Nevelito 6c17503
test spec
Nevelito f9e388d
Add comments
Nevelito 216f486
final changes
Nevelito 1606c2c
fix standardrb
Nevelito 0007f80
fix spec and optymalize code
Nevelito 3a09267
fix spec
Nevelito 553750e
back changes from review
Nevelito a3880d1
fix
Nevelito a8e55b9
final request changes
Nevelito c200f99
optymalize code
Nevelito 5304baf
add tyes to spec and try to reduce complexity
Nevelito 85e1fa8
Fix spec
Nevelito 7434c50
fix field options
Nevelito f0ca28d
fix field options
Nevelito 2cde6aa
Request changes
Nevelito 055578b
fix bug with types
Nevelito a2a78b9
Delete changes in application_record and create new class in resource…
Nevelito 8f0b440
fix standardrb fail
Nevelito e094037
fix whitespace
Nevelito d7adb9a
Add comments
Nevelito File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Method
detect_polymorphic_associations
has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.