Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: drop universalid dependency #3654

Merged
merged 2 commits into from
Feb 11, 2025
Merged

Conversation

Paul-Bob
Copy link
Contributor

Description

Fixes #3650

This PR drops the universalid gem as it relies on config gem, which has been causing multiple issues.

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

@Paul-Bob Paul-Bob self-assigned this Feb 11, 2025
@github-actions github-actions bot added the Chore label Feb 11, 2025
Copy link

codeclimate bot commented Feb 11, 2025

Code Climate has analyzed commit 21e001f and detected 0 issues on this pull request.

View more on Code Climate.

@Paul-Bob Paul-Bob merged commit 8921cbd into main Feb 11, 2025
20 checks passed
@Paul-Bob Paul-Bob deleted the chore/drop_universalid_dependency branch February 11, 2025 10:22
Copy link
Contributor

This PR has been merged into main. The functionality will be available in the next release.

Please check the release guide for more information.

@adrianthedev
Copy link
Collaborator

Let's revert it when this gets fixed hopsoft/universalid#39

@jagthedrummer
Copy link

Just chiming in here to say that it would be nice if there were some way for universalid to be an optional dependency. I'm looking at trimming down memory use on the Bullet Train starter repo and derailed_benchmarks is pointing to avo being one of the larger BT dependencies, and it says that universalid accounts for much of the size. Maybe avo could detect whether universalid is loaded and change behavior in response?

@Paul-Bob
Copy link
Contributor Author

universalid was removed as dependency and released in Avo 3.17.5

Interesting idea on the optional dependency, thanks for sharing it. we'll consider it when reverting the dependency

@adrianthedev
Copy link
Collaborator

Hey @jagthedrummer.

If the problem at the dependency level or the memory usage on runtime?

Also, how did you measure the impact? I'd love to be able to run tests on our side as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Config gem not working in latest release
3 participants