Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

set the queue length to original values after test #2893

Merged
merged 1 commit into from
Oct 2, 2024
Merged

set the queue length to original values after test #2893

merged 1 commit into from
Oct 2, 2024

Conversation

vaishnavibhat
Copy link
Contributor

ethtool -L option tests for different rx and tx length. The patch works on retrieving the original values for the interface and setting the rx and tx values to original values after the test.

@vaishnavibhat
Copy link
Contributor Author

Before test:
ethtool -l eth1
Channel parameters for eth1:
Pre-set maximums:
RX: 16
TX: 16
Other: n/a
Combined: n/a
Current hardware settings:
RX: 8
TX: 2
Other: n/a
Combined: n/a

During test:
ethtool -l eth1
Channel parameters for eth1:
Pre-set maximums:
RX: 16
TX: 16
Other: n/a
Combined: n/a
Current hardware settings:
RX: 9
TX: 3
Other: n/a
Combined: n/a

ethtool -l eth1
Channel parameters for eth1:
Pre-set maximums:
RX: 16
TX: 16
Other: n/a
Combined: n/a
Current hardware settings:
RX: 10
TX: 10
Other: n/a
Combined: n/a

After test: (value reset back to original queue length)
ethtool -l eth1
Channel parameters for eth1:
Pre-set maximums:
RX: 16
TX: 16
Other: n/a
Combined: n/a
Current hardware settings:
RX: 8
TX: 2
Other: n/a
Combined: n/a

@vaishnavibhat
Copy link
Contributor Author

avocado run ethtool_test.py -m ethtool_vnic_test.yaml --max-parallel-tasks=1
JOB ID : 9d0560f21e191de83fad36a1ae9b055d7a89989d
JOB LOG : /root/avocado-fvt-wrapper/results/job-2024-09-11T06.00-9d0560f/job.log
(1/9) ethtool_test.py:Ethtool.test_ethtool;run-args-PrivateFlag-7b2c: STARTED
(1/9) ethtool_test.py:Ethtool.test_ethtool;run-args-PrivateFlag-7b2c: CANCEL: Device Doesn't support Private flags (4.27 s)
(2/9) ethtool_test.py:Ethtool.test_ethtool;run-args-Driver-3ca4: STARTED
(2/9) ethtool_test.py:Ethtool.test_ethtool;run-args-Driver-3ca4: PASS (7.08 s)
(3/9) ethtool_test.py:Ethtool.test_ethtool;run-args-RingParameter-0624: STARTED
(3/9) ethtool_test.py:Ethtool.test_ethtool;run-args-RingParameter-0624: PASS (7.11 s)
(4/9) ethtool_test.py:Ethtool.test_ethtool;run-args-ShowOffloadProtocolFeature-fb76: STARTED
(4/9) ethtool_test.py:Ethtool.test_ethtool;run-args-ShowOffloadProtocolFeature-fb76: PASS (7.03 s)
(5/9) ethtool_test.py:Ethtool.test_ethtool;run-args-Statistics-c286: STARTED
(5/9) ethtool_test.py:Ethtool.test_ethtool;run-args-Statistics-c286: PASS (7.07 s)
(6/9) ethtool_test.py:Ethtool.test_ethtool;run-args-Show-permaddr-402c: STARTED
(6/9) ethtool_test.py:Ethtool.test_ethtool;run-args-Show-permaddr-402c: PASS (7.17 s)
(7/9) ethtool_test.py:Ethtool.test_ethtool;run-args-Show-time-stamping-16f5: STARTED
(7/9) ethtool_test.py:Ethtool.test_ethtool;run-args-Show-time-stamping-16f5: PASS (7.15 s)
(8/9) ethtool_test.py:Ethtool.test_ethtool;run-args-Show-channels-136a: STARTED
(8/9) ethtool_test.py:Ethtool.test_ethtool;run-args-Show-channels-136a: PASS (7.17 s)
(9/9) ethtool_test.py:Ethtool.test_ethtool;run-args-Set-channels-combined_channel-other_channel-1ee2: STARTED
(9/9) ethtool_test.py:Ethtool.test_ethtool;run-args-Set-channels-combined_channel-other_channel-1ee2: PASS (83.60 s)
RESULTS : PASS 8 | ERROR 0 | FAIL 0 | SKIP 0 | WARN 0 | INTERRUPT 0 | CANCEL 1
JOB HTML : /root/avocado-fvt-wrapper/results/job-2024-09-11T06.00-9d0560f/results.html
JOB TIME : 461.77 s

job.log

debug.log

@Naresh-ibm Naresh-ibm self-assigned this Sep 12, 2024
Naresh-ibm
Naresh-ibm requested changes Sep 12, 2024
View reviewed changes
io/net/ethtool_test.py Outdated Show resolved Hide resolved
io/net/ethtool_test.py Outdated Show resolved Hide resolved
@Naresh-ibm
Copy link
Collaborator

@vaishnavibhat can you please re-push the code with suggestion?

@vaishnavibhat vaishnavibhat force-pushed the ethtool_fix branch 2 times, most recently from e8bb068 to 3c06795 Compare September 25, 2024 07:02
Naresh-ibm
Naresh-ibm reviewed Sep 25, 2024
View reviewed changes
io/net/ethtool_test.py Outdated Show resolved Hide resolved
@vaishnavibhat
set the queue length to original values after test
eee658f 
ethtool -L option tests for different rx and tx length.
The patch works on retrieving the original values for the
interface and setting the rx and tx values to original
values after the test.

Signed-off-by: Vaishnavi Bhat <[email protected]>
abdhaleegit
abdhaleegit approved these changes Oct 1, 2024
View reviewed changes
Copy link
Collaborator

@abdhaleegit abdhaleegit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Naresh-ibm
Naresh-ibm approved these changes Oct 2, 2024
View reviewed changes
Copy link
Collaborator

@Naresh-ibm Naresh-ibm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Thanks for PR

@Naresh-ibm Naresh-ibm merged commit b90d2e6 into avocado-framework-tests:master Oct 2, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Naresh-ibm Naresh-ibm Naresh-ibm approved these changes

@abdhaleegit abdhaleegit abdhaleegit approved these changes

Assignees

@Naresh-ibm Naresh-ibm

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vaishnavibhat @Naresh-ibm @abdhaleegit