Added fix to run every if/else statements in case of failure. #2902
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lparstat test have multiple if/else statements to check for different options, if one fails then test execution stops, added fix to execute every statement and check failure at the end. Signed-off-by: Krishan Gopal Saraswat <[email protected]>
PraveenPenguin
merged commit 1519656
into
avocado-framework-tests:master
3 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lparstat test have multiple if/else statements to check for different options, if one fails then test execution stops, added fix to execute every statement and check failure at the end.
We can see multiple Fail conditions getting executed.
[root@ltcrain8oj-lp7 ras]# avocado run --max-parallel-tasks=1 ras_ppcutils.py:test_lparstat
JOB ID : 690e2d43f40fde6cc7cb8216971d1a21e1dfcd77
JOB LOG : /root/avocado-fvt-wrapper/results/job-2024-10-03T22.44-690e2d4/job.log
(1/1) ras_ppcutils.py:RASToolsPpcutils.test_lparstat: STARTED
(1/1) ras_ppcutils.py:RASToolsPpcutils.test_lparstat: FAIL: ['Normalised busy plus idle value does not match with Frequency percentage', 'number of physical processors consumed are not displaying correct'] (11.28 s)
RESULTS : PASS 0 | ERROR 0 | FAIL 1 | SKIP 0 | WARN 0 | INTERRUPT 0 | CANCEL 0
JOB HTML : /root/avocado-fvt-wrapper/results/job-2024-10-03T22.44-690e2d4/results.html
JOB TIME : 26.63 s
Test summary:
1-ras_ppcutils.py:RASToolsPpcutils.test_lparstat: FAIL