Pylint Error Handling #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harvey0100
force-pushed
the
pylinterrorfix
branch
from
7e8bdcd to
f6fd2de
Compare
richtja
requested changes
Oct 9, 2024
There was a problem hiding this comment.
Hi @harvey0100, thanks for your fix. This is a suitable solution, and it works well, I just think that we might simplify it a little bit by using the command in IF clause instead of creating a new variable. Please let me know what do you think.
Corrected error handling, check-lint now displays correct exit codes on exit instead of only displaying the last executed commands exit code, keeps track of all failures and displays correct exit code if any failures were present. Reference: avocado-framework#11 Signed-off-by: Harvey Lynden <[email protected]>
harvey0100
force-pushed
the
pylinterrorfix
branch
from
f6fd2de to
30f0a18
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Corrected error handling, check-lint now displays
correct exit codes on exit instead of only displaying the last executed commands exit code, keeps track of all failures and displays correct exit code if any failures were present.
Reference: #11