Skip to content

Commit

Permalink
Assets: Just-in-Time enqueueueueing.
Browse files Browse the repository at this point in the history
This commit re-enqueues assets anytime calendar & list functions are called. This may cause issues for folks who are hoping to dequeue our core styling, but it does improve support for theme frameworks and site builders.

See #249.
  • Loading branch information
JJJ committed Feb 11, 2022
1 parent 5798a18 commit eaded31
Show file tree
Hide file tree
Showing 2 changed files with 20 additions and 4 deletions.
4 changes: 4 additions & 0 deletions sugar-calendar/includes/themes/legacy/hooks.php
Original file line number Diff line number Diff line change
Expand Up @@ -44,4 +44,8 @@
add_action( 'sc_before_event_content', 'sc_add_event_details' );
add_action( 'sc_event_details', 'sc_add_date_time_details' );
add_action( 'sc_event_details', 'sc_add_location_details' );

// Just-in-Time Assets
add_action( 'sc_before_calendar', 'sc_enqueue_assets' );
add_action( 'sc_before_events_list', 'sc_enqueue_assets' );
}
20 changes: 16 additions & 4 deletions sugar-calendar/includes/themes/legacy/scripts.php
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,20 @@ function sc_register_assets() {
);
}

/**
* Enqueue front-end assets.
*
* @since 2.3.0
*/
function sc_enqueue_assets() {

// Scripts
sc_enqueue_scripts();

// Styles
sc_enqueue_styles();
}

/**
* Load front-end scripts.
*
Expand All @@ -60,8 +74,7 @@ function sc_load_front_end_scripts() {
||
sc_content_has_shortcodes()
) {
sc_enqueue_scripts();
sc_enqueue_styles();
sc_enqueue_assets();
}
}

Expand Down Expand Up @@ -126,8 +139,7 @@ function sc_enqueue_if_block_has_shortcodes( $content = '' ) {

// Check the block content for a shortcode
if ( sc_content_has_shortcodes( $content ) ) {
sc_enqueue_scripts();
sc_enqueue_styles();
sc_enqueue_assets();
}

// Return the content, unchanged
Expand Down

0 comments on commit eaded31

Please sign in to comment.