feat: add policy variable support #415

sameerzuberi · 2024-01-05T20:14:55Z

Issue #, if available:

Description of changes:

Adding policy variable support for thing names.
Updating PermissionEvaluationUtils to use non static methods for future wildcard support

Why is this change necessary:

How was this change tested:
Unit and integration tests

Any additional information or context required to review the change:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

…ermissions (#349)

...eengrass/integrationtests/deviceauth/EvaluateClientDeviceActionsWithPolicyVariablesTest.java

jcosentino11 · 2024-01-05T23:35:54Z

src/main/java/com/aws/greengrass/clientdevices/auth/DeviceAuthClient.java

-        return PermissionEvaluationUtils.isAuthorized(request.getOperation(), request.getResource(),
-                groupManager.getApplicablePolicyPermissions(session));
+        return permissionEvaluationUtils.isAuthorized(request.getOperation(), request.getResource(),
+                permissionEvaluationUtils.transformGroupPermissionsWithVariableValue(session,


while we're at it, we can clean up by making groupManager a dependency of PermissionEvaluationUtils, then we can do something like

permissionEvaluationUtils.isAuthorized(request, session)

lets also take performance into account, e.g. when evaluating w/ same permissions we shouldn't do variable substitution again

lets also take performance into account, e.g. when evaluating w/ same permissions we shouldn't do variable substitution again

Thinking through this more, variables are substituted based on current session, so a caching solution for this would be a bit more involved, assuming it would even be useful, so lets table for now

jcosentino11 · 2024-01-08T19:01:41Z

src/main/java/com/aws/greengrass/clientdevices/auth/PermissionEvaluationUtils.java

@@ -60,7 +66,8 @@ public static boolean isAuthorized(String operation, String resource,
            return false;
        }

-        for (Map.Entry<String, Set<Permission>> entry : groupToPermissionsMap.entrySet()) {
+        for (Map.Entry<String, Set<Permission>> entry :
+                groupToPermissionsMap.entrySet()) {


nit: do we need this formatting change?

jcosentino11 · 2024-01-08T19:10:32Z

src/main/java/com/aws/greengrass/clientdevices/auth/DeviceAuthClient.java

-        return PermissionEvaluationUtils.isAuthorized(request.getOperation(), request.getResource(),
-                groupManager.getApplicablePolicyPermissions(session));
+        return permissionEvaluationUtils.isAuthorized(request.getOperation(), request.getResource(),
+                permissionEvaluationUtils.transformGroupPermissionsWithVariableValue(session,


lets also take performance into account, e.g. when evaluating w/ same permissions we shouldn't do variable substitution again

src/main/java/com/aws/greengrass/clientdevices/auth/PermissionEvaluationUtils.java

github-actions · 2024-01-09T02:01:47Z

Code Coverage Report

File	Coverage
All files	`73%`	✅
com.aws.greengrass.clientdevices.auth.PermissionEvaluationUtils	`77%`	✅
com.aws.greengrass.clientdevices.auth.CertificateManager	`88%`	✅
com.aws.greengrass.clientdevices.auth.ClientDevicesAuthService	`79%`	✅
com.aws.greengrass.clientdevices.auth.DeviceAuthClient	`73%`	✅
com.aws.greengrass.clientdevices.auth.certificate.ClientCertificateGenerator	`95%`	✅
com.aws.greengrass.clientdevices.auth.certificate.CertificateHelper	`74%`	✅
com.aws.greengrass.clientdevices.auth.certificate.CertificateStore	`72%`	✅
com.aws.greengrass.clientdevices.auth.certificate.CertificateExpiryMonitor	`77%`	✅
com.aws.greengrass.clientdevices.auth.certificate.ServerCertificateGenerator	`93%`	✅
com.aws.greengrass.clientdevices.auth.certificate.CertificateGenerator	`70%`	✅
com.aws.greengrass.clientdevices.auth.certificate.CertificateExpiryMonitor$CertRotationDecider	`90%`	✅
com.aws.greengrass.clientdevices.auth.iot.usecases.VerifyIotCertificate	`94%`	✅
com.aws.greengrass.clientdevices.auth.iot.usecases.VerifyThingAttachedToCertificate	`89%`	✅
com.aws.greengrass.clientdevices.auth.iot.usecases.CreateIoTThingSession	`67%`	✅
com.aws.greengrass.clientdevices.auth.iot.usecases.VerifyCertificateValidityPeriod	`88%`	✅
com.aws.greengrass.clientdevices.auth.certificate.infra.BackgroundCertificateRefresh	`82%`	✅
com.aws.greengrass.clientdevices.auth.iot.infra.ThingRegistry	`92%`	✅
com.aws.greengrass.clientdevices.auth.certificate.usecases.ConfigureManagedCertificateAuthority	`85%`	✅
com.aws.greengrass.clientdevices.auth.certificate.usecases.ConfigureCustomCertificateAuthority	`83%`	✅
com.aws.greengrass.clientdevices.auth.certificate.usecases.RegisterCertificateAuthorityUseCase	`65%`	✅
com.aws.greengrass.clientdevices.auth.configuration.MetricsConfiguration	`83%`	✅
com.aws.greengrass.clientdevices.auth.configuration.GroupManager	`89%`	✅
com.aws.greengrass.clientdevices.auth.configuration.CAConfiguration	`96%`	✅
com.aws.greengrass.clientdevices.auth.configuration.RuntimeConfiguration	`83%`	✅
com.aws.greengrass.clientdevices.auth.configuration.SecurityConfiguration	`80%`	✅
com.aws.greengrass.clientdevices.auth.configuration.GroupDefinition	`75%`	✅
com.aws.greengrass.clientdevices.auth.configuration.ExpressionVisitor	`84%`	✅
com.aws.greengrass.clientdevices.auth.configuration.GroupConfiguration	`92%`	✅
com.aws.greengrass.clientdevices.auth.api.ClientDevicesAuthServiceApi	`85%`	✅
com.aws.greengrass.clientdevices.auth.api.GetCertificateRequestWithGenerator	`75%`	✅
com.aws.greengrass.clientdevices.auth.api.UseCases	`71%`	✅
com.aws.greengrass.clientdevices.auth.session.attribute.WildcardSuffixAttribute	`96%`	✅
com.aws.greengrass.clientdevices.auth.iot.IotAuthClient$Default	`56%`	✅
com.aws.greengrass.clientdevices.auth.iot.Thing	`85%`	✅
com.aws.greengrass.clientdevices.auth.iot.Certificate	`74%`	✅
com.aws.greengrass.clientdevices.auth.iot.GreengrassV2DataClientFactory	`18%`	❌
com.aws.greengrass.clientdevices.auth.iot.CertificateRegistry	`95%`	✅
com.aws.greengrass.clientdevices.auth.infra.NetworkStateProvider$Default	`83%`	✅
com.aws.greengrass.ipc.IPCUtils	`83%`	✅
com.aws.greengrass.ipc.VerifyClientDeviceIdentityOperationHandler	`60%`	✅
com.aws.greengrass.ipc.GetClientDeviceAuthTokenOperationHandler	`83%`	✅
com.aws.greengrass.ipc.AuthorizeClientDeviceActionOperationHandler	`79%`	✅
com.aws.greengrass.ipc.SubscribeToCertificateUpdatesOperationHandler	`81%`	✅
com.aws.greengrass.clientdevices.auth.session.SessionConfig	`92%`	✅
com.aws.greengrass.clientdevices.auth.session.SessionManager	`88%`	✅
com.aws.greengrass.clientdevices.auth.certificate.handlers.CAConfigurationChangedHandler	`93%`	✅
com.aws.greengrass.clientdevices.auth.certificate.handlers.CertificateRotationHandler	`96%`	✅
com.aws.greengrass.clientdevices.auth.metrics.handlers.SessionCreationEventHandler	`88%`	✅
com.aws.greengrass.clientdevices.auth.metrics.handlers.MetricsConfigurationChangedHandler	`70%`	✅
com.aws.greengrass.clientdevices.auth.metrics.handlers.AuthorizeClientDeviceActionsMetricHandler	`88%`	✅
com.aws.greengrass.clientdevices.auth.metrics.handlers.VerifyClientDeviceIdentityEventHandler	`88%`	✅
com.aws.greengrass.clientdevices.auth.metrics.handlers.CertificateSubscriptionEventHandler	`83%`	✅
com.aws.greengrass.clientdevices.auth.util.ResizableLinkedBlockingQueue	`90%`	✅
com.aws.greengrass.clientdevices.auth.util.ParseIPAddress	`90%`	✅
com.aws.greengrass.clientdevices.auth.connectivity.CISShadowMonitor$SucceedOnceOperation	`88%`	✅
com.aws.greengrass.clientdevices.auth.connectivity.CISShadowMonitor	`79%`	✅
com.aws.greengrass.clientdevices.auth.connectivity.CISShadowMonitor$ProcessCISShadowTask	`76%`	✅
com.aws.greengrass.clientdevices.auth.connectivity.CISShadowMonitor$CISShadowTaskQueue	`74%`	✅
com.aws.greengrass.clientdevices.auth.connectivity.HostAddress	`67%`	✅
com.aws.greengrass.clientdevices.auth.connectivity.CISShadowMonitor$CISShadowTaskExecutor	`95%`	✅
com.aws.greengrass.clientdevices.auth.configuration.parser.TokenMgrError	`22%`	❌
com.aws.greengrass.clientdevices.auth.configuration.parser.RuleExpressionTokenManager	`61%`	✅
com.aws.greengrass.clientdevices.auth.configuration.parser.ASTStart	`33%`	❌
com.aws.greengrass.clientdevices.auth.configuration.parser.ASTAnd	`67%`	✅
com.aws.greengrass.clientdevices.auth.configuration.parser.Token	`58%`	✅
com.aws.greengrass.clientdevices.auth.configuration.parser.RuleExpressionDefaultVisitor	`0%`	❌
com.aws.greengrass.clientdevices.auth.configuration.parser.ASTOr	`67%`	✅
com.aws.greengrass.clientdevices.auth.configuration.parser.SimpleCharStream	`28%`	❌
com.aws.greengrass.clientdevices.auth.configuration.parser.RuleExpressionTreeConstants	`0%`	❌
com.aws.greengrass.clientdevices.auth.configuration.parser.JJTRuleExpressionState	`67%`	✅
com.aws.greengrass.clientdevices.auth.configuration.parser.ASTThing	`67%`	✅
com.aws.greengrass.clientdevices.auth.configuration.parser.RuleExpression	`63%`	✅
com.aws.greengrass.clientdevices.auth.configuration.parser.SimpleNode	`27%`	❌

Minimum allowed coverage is 50%

Generated by 🐒 cobertura-action against cdfc054

jcosentino11 · 2024-01-09T18:15:17Z

src/main/java/com/aws/greengrass/clientdevices/auth/PermissionEvaluationUtils.java

+                }
+            } else {
+                logger.atWarn().kv("policyVariable", policyVariable)
+                        .log("Policy variable detected but could not be parsed");


policy variable unsupported, and can also guide user w/ next steps (e.g. fix config)

jcosentino11 · 2024-01-09T18:18:55Z

src/main/java/com/aws/greengrass/clientdevices/auth/PermissionEvaluationUtils.java

+            String attributeName = vars[2];
+
+            // this supports the ThingName attribute only
+            if (THING_NAME_VARIABLE.equals(policyVariable)) {


i think we'd want to be case insensitive, would need to configure the matcher too

jcosentino11 · 2024-01-09T18:24:34Z

src/main/java/com/aws/greengrass/clientdevices/auth/PermissionEvaluationUtils.java

+                        Coerce.toString(session.getSessionAttribute(attributeNamespace, attributeName));
+
+                if (policyVariableValue == null) {
+                    logger.atWarn().kv("attributeName", attributeName)


i think we'd want to error here rather than log, it's a failure mode--not doing substitution would mean the policy is acting differently than intended

src/main/java/com/aws/greengrass/clientdevices/auth/PermissionEvaluationUtils.java

src/main/java/com/aws/greengrass/clientdevices/auth/iot/Component.java

jcosentino11 · 2024-01-26T22:00:40Z

src/main/java/com/aws/greengrass/clientdevices/auth/PermissionEvaluationUtils.java

+    private static final Map<String, Pair<String,String>> policyVariableResolver =
+            new HashMap<String, Pair<String,String>>() {
+        {
+            put("iot:Connection.Thing.ThingName", new Pair<>("Thing", "ThingName"));


lets make the attr namespace and properties constants

jcosentino11 · 2024-01-26T22:01:14Z

src/main/java/com/aws/greengrass/clientdevices/auth/PermissionEvaluationUtils.java

+
+    private static final Map<String, Pair<String,String>> policyVariableResolver =
+            new HashMap<String, Pair<String,String>>() {
+        {


nit: avoid {{}} initializers

jcosentino11 · 2024-01-26T22:28:02Z

src/main/java/com/aws/greengrass/clientdevices/auth/PermissionEvaluationUtils.java

+                }
+            } else {
+                logger.atWarn().kv("policyVariable", policyVariable)
+                        .log("Policy variable unsupported. Only thing name variables are supported, please fix the "


Only thing name variables are supported

let's remove, otherwise we'll have to update this every time we add new ones

jcosentino11 · 2024-01-26T22:45:01Z

Putting here for later reference:

With regex on the policy eval path, throughput is ~200k ops/s (for variable substitution test case). Before we were hitting 400k.

We talked about identifying variables during config time, which should get those perf numbers back up

src/main/java/com/aws/greengrass/clientdevices/auth/PermissionEvaluationUtils.java

src/main/java/com/aws/greengrass/clientdevices/auth/iot/Thing.java

src/main/java/com/aws/greengrass/clientdevices/auth/iot/Certificate.java

jcosentino11 · 2024-01-30T23:57:49Z

src/main/java/com/aws/greengrass/clientdevices/auth/configuration/Permission.java

@@ -17,4 +20,10 @@ public class Permission {
    @NonNull String operation;

    @NonNull String resource;


nit: i think renaming to resourceFormat or similar would make it clearer that this shouldn't be used directly anymore

jcosentino11 · 2024-01-30T23:58:57Z

src/main/java/com/aws/greengrass/clientdevices/auth/configuration/Permission.java

@@ -17,4 +20,10 @@ public class Permission {
    @NonNull String operation;

    @NonNull String resource;
+
+    List<String> policyVariables;


lets name this resourcePolicyVariables, since these don't apply to operation or principal

jcosentino11 · 2024-01-31T00:03:42Z

src/main/java/com/aws/greengrass/clientdevices/auth/configuration/PolicyVariableResolver.java

+     * @param session current device session
+     * @return updated resource
+     */
+    public static String resolvePolicyVariables(List<String> policyVariables, String resource, Session session) {


note: in follow up we'll also need to add more validations to the policy (e.g. bad policy variable name, etc), after #418 is merged too

jcosentino11 · 2024-01-31T00:07:34Z

src/main/java/com/aws/greengrass/clientdevices/auth/configuration/PolicyVariableResolver.java

+    private static final String THING_NAMESPACE = "Thing";
+    private static final String THING_NAME_ATTRIBUTE = "ThingName";
+
+    static {


Utils.immutableMap

jcosentino11 · 2024-01-31T00:07:52Z

src/main/java/com/aws/greengrass/clientdevices/auth/configuration/PolicyVariableResolver.java

+import java.util.Map;
+
+public final class PolicyVariableResolver {
+    private static final Map<String, Pair<String,String>> policyVariableMap;


could use a more descriptive name

jcosentino11 · 2024-01-31T00:12:16Z

src/main/java/com/aws/greengrass/clientdevices/auth/configuration/PolicyVariableResolver.java

+            String policyVariableValue = Coerce.toString(session.getSessionAttribute(attributeNamespace,
+                    attributeName));
+            if (policyVariableValue == null) {
+                throw new IllegalArgumentException("No attribute found for current session");


lets avoid unchecked exceptions, may need to make your own if there's not a suitable one

include attribute name/space in message as well

jcosentino11 · 2024-01-31T00:13:21Z

src/main/java/com/aws/greengrass/clientdevices/auth/configuration/PolicyVariableResolver.java

+            if (policyVariableValue == null) {
+                throw new IllegalArgumentException("No attribute found for current session");
+            } else {
+                substitutedResource = StringUtils.replace(substitutedResource, policyVariable, policyVariableValue);


probably worth a quick comment about why this replace impl

jcosentino11 · 2024-01-31T00:21:39Z

src/test/java/com/aws/greengrass/clientdevices/auth/ClientDevicesAuthServiceTest.java

@@ -198,19 +198,19 @@ void GIVEN_valid_group_configuration_WHEN_start_service_THEN_instantiated_config

        Permission[] tempSensorPermissions =
                {Permission.builder().principal("myTemperatureSensors").operation("mqtt" + ":connect")
-                        .resource("mqtt:clientId:foo").build(),
+                        .resource("mqtt:clientId:foo").policyVariables(Collections.emptyList()).build(),


would also be ok to default policyVariables to empty list within Permission itself

jcosentino11 · 2024-01-31T22:54:58Z

src/main/java/com/aws/greengrass/clientdevices/auth/exception/AttributeProviderException.java

+
+package com.aws.greengrass.clientdevices.auth.exception;
+
+public class AttributeProviderException extends Exception {


nit: how about PolicyException?

jcosentino11 · 2024-01-31T22:56:37Z

src/main/java/com/aws/greengrass/clientdevices/auth/iot/Thing.java

-        // TODO: Return other possible DeviceAttributes
-        return null;
+        // TODO: Support other DeviceAttributes
+        return new WildcardSuffixAttribute(thingName);


from convo: if we want to still have attributeName passed in we'll need to use it, otherwise would need to be reverted back to just getDeviceAttributes() that returns a map

src/main/java/com/aws/greengrass/clientdevices/auth/configuration/PolicyVariableResolver.java

src/main/java/com/aws/greengrass/clientdevices/auth/PermissionEvaluationUtils.java

src/main/java/com/aws/greengrass/clientdevices/auth/configuration/PolicyVariableResolver.java

… npe

cyyan88 and others added 6 commits June 26, 2023 15:38

feat: utility method for policy variable support (#339)

f8f4a57

feat: utility method for updating permissions for device (#344)

dc5ff68

fix: add support for replacing multiple policy variables (#346)

bc3042b

feat: allow device actions to be evaluated based on policy variable p…

2fdf274

…ermissions (#349)

feat: add integration test for policy variable authorization (#355)

a73113f

feat: make PermissionEvaluationUtils non static

efa45c5

sameerzuberi mentioned this pull request Jan 5, 2024

feat: wildcard support #390

Merged

fix: check style

1193d04

sameerzuberi force-pushed the policy-variable-support branch from 5a4cbbb to 1193d04 Compare January 5, 2024 20:22

fix: pmd

c44eef6

sameerzuberi force-pushed the policy-variable-support branch from 0470133 to c44eef6 Compare January 5, 2024 20:29

github-advanced-security bot found potential problems Jan 5, 2024

View reviewed changes

...eengrass/integrationtests/deviceauth/EvaluateClientDeviceActionsWithPolicyVariablesTest.java Fixed Show fixed Hide fixed

jcosentino11 reviewed Jan 5, 2024

View reviewed changes

jcosentino11 reviewed Jan 8, 2024

View reviewed changes

fix: refactor PermissionEvaluationUtils

87e85b3

sameerzuberi force-pushed the policy-variable-support branch from 027a98b to 87e85b3 Compare January 9, 2024 00:59

MikeDombo reviewed Jan 9, 2024

View reviewed changes

src/main/java/com/aws/greengrass/clientdevices/auth/PermissionEvaluationUtils.java Show resolved Hide resolved

chore: check style

7698ed9

sameerzuberi force-pushed the policy-variable-support branch from a68376e to 7698ed9 Compare January 9, 2024 01:04

fix: remove device auth client mocks

6f755b8

sameerzuberi force-pushed the policy-variable-support branch from 3609884 to 6f755b8 Compare January 9, 2024 01:54

jcosentino11 reviewed Jan 9, 2024

View reviewed changes

fix: remove permission caching

b7bb2cb

sameerzuberi force-pushed the policy-variable-support branch from 5665f8b to b7bb2cb Compare January 9, 2024 18:26

fix: case insensitive matching

6135f3e

sameerzuberi force-pushed the policy-variable-support branch from 0ea3f4c to 6135f3e Compare January 16, 2024 18:17

fix: pmd

f62ea96

sameerzuberi force-pushed the policy-variable-support branch from 0a76038 to f62ea96 Compare January 16, 2024 18:25

Merge branch 'main' into policy-variable-support

f6960dc

robcmann marked this pull request as draft January 26, 2024 21:33

feat: create foundation to support more policy variables

fa815c2

MikeDombo reviewed Jan 26, 2024

View reviewed changes

src/main/java/com/aws/greengrass/clientdevices/auth/PermissionEvaluationUtils.java Show resolved Hide resolved

jcosentino11 reviewed Jan 26, 2024

View reviewed changes

src/main/java/com/aws/greengrass/clientdevices/auth/iot/Component.java Show resolved Hide resolved

jcosentino11 reviewed Jan 26, 2024

View reviewed changes

feat: identify policy variables during config time

990cf66

MikeDombo reviewed Jan 30, 2024

View reviewed changes

src/main/java/com/aws/greengrass/clientdevices/auth/PermissionEvaluationUtils.java Show resolved Hide resolved

jcosentino11 reviewed Jan 31, 2024

View reviewed changes

feat: performance improvements

6994fc0

robcmann marked this pull request as ready for review January 31, 2024 22:44

jcosentino11 reviewed Jan 31, 2024

View reviewed changes

src/main/java/com/aws/greengrass/clientdevices/auth/configuration/PolicyVariableResolver.java Show resolved Hide resolved

chore: renamed attribute provider exception to policy exception

e107f25

jcosentino11 previously approved these changes Feb 1, 2024

View reviewed changes

src/main/java/com/aws/greengrass/clientdevices/auth/configuration/PolicyVariableResolver.java Outdated Show resolved Hide resolved

chore: use set instead of list to store user policy variables

bbb49c9

robcmann dismissed jcosentino11’s stale review via bbb49c9 February 1, 2024 19:13

jcosentino11 previously approved these changes Feb 1, 2024

View reviewed changes

robcmann requested a review from MikeDombo February 1, 2024 19:24

MikeDombo reviewed Feb 1, 2024

View reviewed changes

src/main/java/com/aws/greengrass/clientdevices/auth/PermissionEvaluationUtils.java Outdated Show resolved Hide resolved

MikeDombo reviewed Feb 1, 2024

View reviewed changes

src/main/java/com/aws/greengrass/clientdevices/auth/configuration/PolicyVariableResolver.java Outdated Show resolved Hide resolved

chore: fix policy exception logging and use coerce to string to avoid…

cdfc054

… npe

robcmann dismissed jcosentino11’s stale review via cdfc054 February 1, 2024 20:30

robcmann requested review from jcosentino11 and MikeDombo February 1, 2024 20:50

MikeDombo approved these changes Feb 1, 2024

View reviewed changes

jcosentino11 approved these changes Feb 1, 2024

View reviewed changes

robcmann merged commit 1a7a07a into main Feb 1, 2024
5 checks passed

robcmann deleted the policy-variable-support branch February 1, 2024 21:08

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: add policy variable support #415

feat: add policy variable support #415

sameerzuberi commented Jan 5, 2024

jcosentino11 Jan 5, 2024

jcosentino11 Jan 8, 2024

sameerzuberi Jan 9, 2024

jcosentino11 Jan 9, 2024

jcosentino11 Jan 8, 2024

sameerzuberi Jan 9, 2024

jcosentino11 Jan 8, 2024

github-actions bot commented Jan 9, 2024 •

edited

Loading

jcosentino11 Jan 9, 2024

jcosentino11 Jan 9, 2024

jcosentino11 Jan 9, 2024

jcosentino11 Jan 26, 2024

jcosentino11 Jan 26, 2024

jcosentino11 Jan 26, 2024

jcosentino11 commented Jan 26, 2024 •

edited

Loading

jcosentino11 Jan 30, 2024

jcosentino11 Jan 30, 2024

jcosentino11 Jan 31, 2024

jcosentino11 Jan 31, 2024

jcosentino11 Jan 31, 2024

jcosentino11 Jan 31, 2024

jcosentino11 Jan 31, 2024

jcosentino11 Jan 31, 2024

jcosentino11 Jan 31, 2024

jcosentino11 Jan 31, 2024

jcosentino11 Jan 31, 2024

		@@ -17,4 +20,10 @@ public class Permission {
		@NonNull String operation;

		@NonNull String resource;


		package com.aws.greengrass.clientdevices.auth.exception;

		public class AttributeProviderException extends Exception {

feat: add policy variable support #415

feat: add policy variable support #415

Conversation

sameerzuberi commented Jan 5, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

github-actions bot commented Jan 9, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jcosentino11 commented Jan 26, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

github-actions bot commented Jan 9, 2024 •

edited

Loading

jcosentino11 commented Jan 26, 2024 •

edited

Loading