Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

join configuration change thread from main thread to prevent 'Runtime… #18

Merged
merged 1 commit into from
Sep 19, 2024

Conversation

jamhabr
Copy link
Member

@jamhabr jamhabr commented Sep 17, 2024

Issue #, if available:

Description of changes:

  • Minor changes to Thread handling

Why is this change necessary:

  • Prevent aws.greengrass.DeviceDefender: stdout. RuntimeError: can't create new thread at interpreter shutdown

How was this change tested:

  • reproduced issue by waiting for the existing python script to emit 2 Device Defender metric reports with Python 3.12
  • copied new changes to a local GreenGrass install
  • ran ./bin/greengrass-cli component stop -n aws.greengrass.DeviceDefender and ./bin/greengrass-cli component restart -n aws.greengrass.DeviceDefender multiple times
  • verified there was no error for can't create new thread at interpreter shutdown after 2 Device Metric reports were sent to Device Defender

Any additional information or context required to review the change:

Checklist:

  • Updated the README if applicable
  • Updated or added new unit tests
  • Updated or added new integration tests
  • Updated or added new end-to-end tests
  • If your code makes a remote network call, it was tested with a proxy
  • You confirm that the change is backwards compatible

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

…Error: can't create new thread at interpreter shutdown'
@junfuchen99 junfuchen99 merged commit 5fdf556 into aws-greengrass:main Sep 19, 2024
1 check failed
@jamhabr jamhabr deleted the fix-python312-thread branch September 26, 2024 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants