Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding to README extra-jars option #500

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

edmondop
Copy link

@edmondop edmondop commented Jan 23, 2025

resolves #383

  • I have signed the CLA
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • I have updated the CHANGELOG.md and added information about my change to the "dbt-glue next" section.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copy link
Collaborator

@moomindani moomindani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution. I left a few comments.

@@ -234,14 +234,15 @@ The table below describes all the options.
| security_configuration | The security configuration to use with this session. | no |
| connections | A comma-separated list of connections to use in the session. | no |
| conf | Specific configuration used at the startup of the Glue Interactive Session (arg --conf) | no |
| extra_jar_files | Extra Jar Libs that can be used by the interactive session. | no |
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The valid parameter is extra_jars I thought.

@@ -436,6 +436,8 @@ test_project:
location: "s3://aws-dbt-glue-datalake-1234567890-eu-west-1/"
conf: spark.serializer=org.apache.spark.serializer.KryoSerializer --conf spark.sql.hive.convertMetastoreParquet=false
datalake_formats: hudi
extra_jars: s3://{bucket}/configs/jars/hudi-utilities-bundle_2.12-0.12.1.jar,s3://{bucket}/configs/jars/hudi-spark3.1-bundle_2.12-0.12.1.jar,s3://{bucket}/configs/jars/spark-avro_2.12-3.2.2.jar,s3://{bucket}/configs/jars/calcite-core-1.32.0.jar
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we use some different example? Here are some reasons:

  • Hudi's dependency is bit too complex as an example.
  • Spark version corresponding to Glue 4.0 is 3.3.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing extra_jars option in the readme
2 participants