Skip to content

Commit

Permalink
fix: add physicalName for OIDCProvider
Browse files Browse the repository at this point in the history
  • Loading branch information
WarFox committed Jan 13, 2024
1 parent adc51ad commit 02274f7
Showing 1 changed file with 12 additions and 3 deletions.
15 changes: 12 additions & 3 deletions packages/aws-cdk-lib/aws-iam/lib/oidc-provider2.ts
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,13 @@ export interface IOpenIdConnectProvider2 extends IResource {
* Initialization properties for `OpenIdConnectProvider`.
*/
export interface OpenIdConnectProvider2Props {
/**
* The name of the OIDC Provider.
*
* @default - A name is automatically generated.
*/
readonly oidcProviderName?: string;

/**
* The URL of the identity provider. The URL must begin with https:// and
* should correspond to the iss claim in the provider's OpenID Connect ID
Expand Down Expand Up @@ -107,7 +114,7 @@ export class OpenIdConnectProvider2
): IOpenIdConnectProvider2 {
const resourceName = Arn.extractResourceName(
openIdConnectProviderArn,
'oidc-provider2',
'oidc-provider',
);

class Import extends Resource implements IOpenIdConnectProvider2 {
Expand Down Expand Up @@ -141,7 +148,9 @@ export class OpenIdConnectProvider2
id: string,
props: OpenIdConnectProvider2Props,
) {
super(scope, id);
super(scope, id, {
physicalName: props.oidcProviderName,
});

const resource = new CfnOIDCProvider(this, 'Resource', {
url: props.url,
Expand All @@ -152,7 +161,7 @@ export class OpenIdConnectProvider2
this.openIdConnectProviderArn = Token.asString(resource.ref);
this.openIdConnectProviderIssuer = Arn.extractResourceName(
this.openIdConnectProviderArn,
'oidc-provider2',
'oidc-provider',
);
this.openIdConnectProviderthumbprints = Token.asString(
resource.getAtt('Thumbprints'),
Expand Down

0 comments on commit 02274f7

Please sign in to comment.