-
Notifications
You must be signed in to change notification settings - Fork 4k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix(batch): support cfn parameters for managed compute environment pr…
…operties minvcpus, maxvcpus, and spotbidpercentage (#32954) ### Issue # (if applicable) Closes #32905. ### Reason for this change The Aws Batch Managed Compute Environment L2 currently does not allow for CfnParameter / Tokens for numeric properties that perform validation at synth time. This is a common pattern in other L2's in AWS CDK to skip the validation checks if the property can support being a cloud formation parameter ### Description of changes I updated the validation methods in ManagedComputeEnvironment to skip if the property being validated is a token. Affected properties are spotBidPercentage, minVCpus, and maxVCpus. The logic keeps performing any of the checks if enough information in any of the properties are there to do the check at synth time. ### Describe any new or updated permissions being added N/A ### Description of how you validated changes Added new unit tests ### Checklist - [X] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md) ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
- Loading branch information
1 parent
6fa1d05
commit 5fef9e0
Showing
10 changed files
with
632 additions
and
88 deletions.
There are no files selected for viewing
2 changes: 1 addition & 1 deletion
2
...js.snapshot/BatchManagedComputeEnvironmentTestDefaultTestDeployAssertD4528F80.assets.json
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
6 changes: 3 additions & 3 deletions
6
...test/aws-batch/test/integ.managed-compute-environment.js.snapshot/batch-stack.assets.json
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2
...framework-integ/test/aws-batch/test/integ.managed-compute-environment.js.snapshot/cdk.out
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
2 changes: 1 addition & 1 deletion
2
...mework-integ/test/aws-batch/test/integ.managed-compute-environment.js.snapshot/integ.json
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
58 changes: 50 additions & 8 deletions
58
...ork-integ/test/aws-batch/test/integ.managed-compute-environment.js.snapshot/manifest.json
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Oops, something went wrong.