Skip to content

Commit

Permalink
chore: check-pack-prerequisites checks for python 3.8 now (#28054)
Browse files Browse the repository at this point in the history
Minimum required version enforced by jsii-pacmak.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
  • Loading branch information
kaizencc authored Nov 17, 2023
1 parent b341f26 commit a1a6131
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,7 @@ The following tools need to be installed on your system prior to installing the
- We recommend using a version in [Active LTS](https://nodejs.org/en/about/releases/)
- [Yarn >= 1.19.1, < 2](https://yarnpkg.com/lang/en/docs/install)
- [.NET SDK >= 6.0.x](https://www.microsoft.com/net/download)
- [Python >= 3.6.5, < 4.0](https://www.python.org/downloads/release/python-365/)
- [Python >= 3.8.0, < 4.0](https://www.python.org/downloads/release/python-380/)
- [Docker >= 19.03](https://docs.docker.com/get-docker/)
- the Docker daemon must also be running

Expand Down
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ The CDK is available in the following languages:

* JavaScript, TypeScript ([Node.js ≥ 14.15.0](https://nodejs.org/download/release/latest-v14.x/))
* We recommend using a version in [Active LTS](https://nodejs.org/en/about/previous-releases)
* Python ([Python ≥ 3.6](https://www.python.org/downloads/))
* Python ([Python ≥ 3.8](https://www.python.org/downloads/))
* Java ([Java ≥ 8](https://www.oracle.com/technetwork/java/javase/downloads/index.html) and [Maven ≥ 3.5.4](https://maven.apache.org/download.cgi))
* .NET ([.NET ≥ 6.0](https://dotnet.microsoft.com/download))
* Go ([Go ≥ 1.16.4](https://golang.org/))
Expand Down
4 changes: 2 additions & 2 deletions scripts/check-pack-prerequisites.sh
Original file line number Diff line number Diff line change
Expand Up @@ -86,9 +86,9 @@ else
wrong_version
fi

# [Python >= 3.6.5, < 4.0]
# [Python >= 3.8.0, < 4.0]
app="python3"
app_min="3.6.5"
app_min="3.8.0"
check_which $app $app_min
app_v=$(${app} --version)
echo -e "Checking $app version... \c"
Expand Down

0 comments on commit a1a6131

Please sign in to comment.