fix(lambda-nodejs): docker image is built when not required

[tmokmss]

This is a small optimization to get rid of unnecessary building of container images. Currently the docker image required for NodejsFunction bundling (e.g. public.ecr.aws/sam/build-nodejs18.x) is always built regardless of necessity, which sometimes makes cdk commands slow.

This PR fixes the current behavior; If bundling is not required for an NodejsFunction's asset, we just skip it, which is also a consistent behavior with PythonFunction.

aws-cdk/packages/@aws-cdk/aws-lambda-python-alpha/lib/bundling.ts

Lines 56 to 62 in de0a9e2

	public static bundle(options: BundlingProps): AssetCode {
	return Code.fromAsset(options.entry, {
	assetHash: options.assetHash,
	assetHashType: options.assetHashType,
	exclude: DEPENDENCY_EXCLUDES,
	bundling: options.skip ? undefined : new Bundling(options),
	});

aws-cdk/packages/@aws-cdk/aws-lambda-python-alpha/lib/function.ts

Line 76 in de0a9e2

skip: !Stack.of(scope).bundlingRequired,

edit) turns out it's not very easy to fix, because currently the construct seems to expect the bundling preprocess always run to work properly.

---

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

[aws-cdk-automation]

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

[tmokmss]

Exemption Request: As far as I know this is kind of a change that cannot be tested with integ-runner, because the change affects cases when we don't deploy a stack.

[aws-cdk-automation]

AWS CodeBuild CI Report

• CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
• Commit ID: b845986
• Result: FAILED
• Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

[aws-cdk-automation]

This PR has been in the CHANGES REQUESTED state for 3 weeks, and looks abandoned. To keep this PR from being closed, please continue work on it. If not, it will automatically be closed in a week.

[aws-cdk-automation]

This PR has been deemed to be abandoned, and will be automatically closed. Please create a new PR for these changes if you think this decision has been made in error.

[aws-cdk-automation]

The pull request linter fails with the following errors:

❌ Fixes must contain a change to an integration test file and the resulting snapshot.

PRs must pass status checks before we can provide a meaningful review.

If you would like to request an exemption from the status checks or clarification on feedback, please leave a comment on this PR containing Exemption Request and/or Clarification Request.