-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: remove uses of aws-sdk outside cli #31275
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
will customers who currently use the old generated metadata thing be broken when they upgrade and suddenly be using the v3 version?
No, it's actually pretty much the same data being generated (v3 is more up-to-date), we were just parsing it in slightly different ways in different locations, with the slight differences not actually resulting in different output. |
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Comments on closed issues and PRs are hard for our team to see. |
Every use of sdkv2, besides what is used inside the cli has been removed as of this change.
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license