docs(gamelift-alpha): fix typos #32881
Conversation
github-actions
bot
added
the
valued-contributor
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #32881 +/- ##
==========================================
+ Coverage 81.38% 81.40% +0.02%
==========================================
Files 222 223 +1
Lines 13695 13727 +32
Branches 2412 2411 -1
==========================================
+ Hits 11145 11175 +30
- Misses 2271 2274 +3
+ Partials 279 278 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
aws-cdk-automation
added
the
pr/needs-community-review
| @@ -644,7 +644,7 @@ export abstract class FleetBase extends cdk.Resource implements IFleet { | |||
| } | |||
|
|
|||
| protected warnVpcPeeringAuthorizations(scope: Construct): void { | |||
| cdk.Annotations.of(scope).addWarningV2('@aws-cdk/aws-gamelift:fleetAutorizeVpcPeering', [ | |||
| cdk.Annotations.of(scope).addWarningV2('@aws-cdk/aws-gamelift:fleetAuthorizeVpcPeering', [ | |||
There was a problem hiding this comment.
As much as this is fixing a typo, changing this value changes observable behavior, and is therefore not okay.
There was a problem hiding this comment.
Thank you. I have restored the points you pointed out.
aws-cdk-automation
removed
the
pr/needs-community-review
aws-cdk-automation
added
the
pr/needs-community-review
There was a problem hiding this comment.
many of these formatting changes in the README i'd prefer not to accept. they're unnecessary, and what we had before was perfectly valid too. the typo fixes are much appreciated though, can we stick to just those changes in this PR? thank you so much for your eagle eyes!
| new gamelift.QueuedMatchmakingConfiguration( | ||
| this, | ||
| "QueuedMatchmakingConfiguration", | ||
| { | ||
| matchmakingConfigurationName: "test-queued-config-name", | ||
| gameSessionQueues: [queue], | ||
| ruleSet: ruleSet, | ||
| } | ||
| ); |
There was a problem hiding this comment.
this is not a typo and i'm not sure i like the formatting change you've put forth.
| new gamelift.StandaloneMatchmakingConfiguration(this, "StandaloneMatchmaking", { | ||
| matchmakingConfigurationName: "test-standalone-config-name", |
There was a problem hiding this comment.
we are generally ok with (and in fact prefer) ' single quotes
| new gamelift.MatchmakingRuleSet(this, "RuleSet", { | ||
| matchmakingRuleSetName: "my-test-ruleset", | ||
| content: gamelift.RuleSetContent.fromJsonFile( | ||
| path.join(__dirname, "my-ruleset", "ruleset.json") | ||
| ), |
There was a problem hiding this comment.
i'm not a fan of these formatting changes
| @@ -132,22 +136,23 @@ matchmaking configuration. | |||
| declare const matchmakingRuleSet: gamelift.MatchmakingRuleSet; | |||
| // Alarm that triggers when the per-second average of not placed matches exceed 10% | |||
| const ruleEvaluationRatio = new cloudwatch.MathExpression({ | |||
| expression: '1 - (ruleEvaluationsPassed / ruleEvaluationsFailed)', | |||
| expression: "1 - (ruleEvaluationsPassed / ruleEvaluationsFailed)", | |||
There was a problem hiding this comment.
again, we're ok with single quotes
aws-cdk-automation
removed
the
pr/needs-community-review
mergify
bot
dismissed
kaizencc’s stale review
Pull request has been modified.
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
aws-cdk-automation
added
the
pr/needs-community-review
aws-cdk-automation
removed
the
pr/needs-community-review
Issue # (if applicable)
None
Reason for this change
Fixed typos in code comments.
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license