chore: re-enable console output in tests #32883
Conversation
Remove `silent: true` from the test config. `console.log()` is a time-honored debugging tradition, and the `silent: true` config makes that not work in a non-obvious way. A nice behavior that many other testing frameworks have is to only print the console output of tests that fail. Use the "Jest Environments" feature to build an environment that replaces `console.log()` etc and buffers their output to only print it for failing tests.
rix0rrr
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #32883 +/- ##
=======================================
Coverage 81.38% 81.38%
=======================================
Files 222 222
Lines 13698 13698
Branches 2413 2413
=======================================
Hits 11148 11148
Misses 2271 2271
Partials 279 279
Flags with carried forward coverage won't be shown. Click here to find out more.
|
aws-cdk-automation
added
the
pr/needs-maintainer-review
| } | ||
|
|
||
| async teardown() { | ||
| this.global.console = this.originalConsole; |
There was a problem hiding this comment.
Doesn't this collide when running tests in parallel? or do they not run in the same process?
There was a problem hiding this comment.
Inside one process tests run sequentially, except when using test.concurrent(). But we only use that in the CLI integ tests, and we're only using this environment in aws-cdk-lib.
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
aws-cdk-automation
removed
the
pr/needs-maintainer-review
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
Comments on closed issues and PRs are hard for our team to see. |
Remove
silent: truefrom the test config.console.log()is a time-honored debugging tradition, and thesilent: trueconfig makes that not work in a non-obvious way.A nice behavior that many other testing frameworks have is to only print the console output of tests that fail. Use the "Jest Environments" feature to build an environment that replaces
console.log()etc and buffers their output to only print it for failing tests.This achieves the same goals of not polluting the terminal too much while running tests, while still allowing the ability to see the output of
console.log.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license