Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: dotnet upgrade from 6.0 -> 8.0 #32894

Merged
merged 2 commits into from
Jan 14, 2025
Merged

chore: dotnet upgrade from 6.0 -> 8.0 #32894

merged 2 commits into from
Jan 14, 2025

Conversation

iankhou
Copy link
Contributor

@iankhou iankhou commented Jan 13, 2025

Issue #32804

Closes #32804

Reason for this change

New projects in C# and F# are initialized using .NET6.0, which was designated EOL 12 NOV 2024.

Description of changes

Upgraded .NET from 6.0 (EOL) -> 8.0 (LTS) for new projects in C# and F#.

Describe any new or updated permissions being added

No permissions changes.

Description of how you validated changes

Changed unit tests to check for .NET8.0 instead of .NET6.0, and ran them successfully.

Screenshot 2025-01-13 at 12 53 25

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@iankhou iankhou self-assigned this Jan 13, 2025
@aws-cdk-automation aws-cdk-automation requested a review from a team January 13, 2025 19:26
@github-actions github-actions bot added the p2 label Jan 13, 2025
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Jan 13, 2025
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@aws-cdk-automation aws-cdk-automation added the pr/needs-cli-test-run This PR needs CLI tests run against it. label Jan 13, 2025
@iankhou iankhou force-pushed the iankhou-dotnet-upgrade branch from f9e71cd to 2b4dc7a Compare January 13, 2025 19:33
@github-actions github-actions bot added bug This issue is a bug. effort/small Small work item – less than a day of effort p1 and removed p2 labels Jan 13, 2025
@iankhou iankhou changed the title Iankhou dotnet upgrade chore: dotnet upgrade from 6.0 -> 8.0 Jan 13, 2025
@aws-cdk-automation aws-cdk-automation dismissed their stale review January 13, 2025 19:39

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

Copy link

codecov bot commented Jan 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.40%. Comparing base (ef135ef) to head (25e7b43).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #32894   +/-   ##
=======================================
  Coverage   81.40%   81.40%           
=======================================
  Files         223      223           
  Lines       13727    13727           
  Branches     2411     2411           
=======================================
  Hits        11175    11175           
  Misses       2274     2274           
  Partials      278      278           
Flag Coverage Δ
suite.unit 81.40% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
packages/aws-cdk 80.74% <ø> (ø)
packages/aws-cdk-lib/core 82.10% <ø> (ø)

@iankhou iankhou marked this pull request as ready for review January 13, 2025 20:52
@iankhou iankhou requested a review from a team as a code owner January 13, 2025 20:52
@rix0rrr rix0rrr added the pr-linter/cli-integ-tested Assert that any CLI changes have been integ tested label Jan 14, 2025
Copy link
Contributor

mergify bot commented Jan 14, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot temporarily deployed to test-pipeline January 14, 2025 07:27 Inactive
@aws-cdk-automation
Copy link
Collaborator

➡️ PR build request submitted to test-main-pipeline ⬅️

A maintainer must now check the pipeline and add the pr-linter/cli-integ-tested label once the pipeline succeeds.

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 25e7b43
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Copy link
Contributor

mergify bot commented Jan 14, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 5a830a0 into main Jan 14, 2025
19 checks passed
@mergify mergify bot deleted the iankhou-dotnet-upgrade branch January 14, 2025 07:57
Copy link

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 14, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug This issue is a bug. contribution/core This is a PR that came from AWS. effort/small Small work item – less than a day of effort p1 pr/needs-cli-test-run This PR needs CLI tests run against it. pr-linter/cli-integ-tested Assert that any CLI changes have been integ tested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CLI: initialises project with out of support version of .NET
3 participants