Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(eslint): enforce spacing at beginning of comments #33077

Merged
merged 17 commits into from
Jan 23, 2025
Merged

chore(eslint): enforce spacing at beginning of comments #33077

merged 17 commits into from
Jan 23, 2025

Conversation

kaizencc
Copy link
Contributor

@kaizencc kaizencc commented Jan 22, 2025 •
edited
Loading

enforces spacing at beginning of comments. we are exempting situations that have /// because they are special comments that jsii recognizes, and situations that have //////// to delineate a split of some sport.

Checklist

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added the p2 label Jan 22, 2025
@aws-cdk-automation aws-cdk-automation requested a review from a team January 22, 2025 22:37
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Jan 22, 2025
@kaizencc kaizencc requested a review from a team as a code owner January 22, 2025 22:50
aws-cdk-automation
aws-cdk-automation previously requested changes Jan 22, 2025
View reviewed changes
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter fails with the following errors:

❌ CLI code has changed. A maintainer must run the code through the testing pipeline (git fetch origin pull/33077/head && git push -f origin FETCH_HEAD:test-main-pipeline), then add the 'pr-linter/cli-integ-tested' label when the pipeline succeeds.

If you believe this pull request should receive an exemption, please comment and provide a justification. A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed, add Clarification Request to a comment.

@kaizencc kaizencc added the pr-linter/cli-integ-tested Assert that any CLI changes have been integ tested label Jan 22, 2025
@kaizencc
Copy link
Contributor Author

No need to integ test as this touches comments only

@aws-cdk-automation aws-cdk-automation dismissed their stale review January 22, 2025 22:58

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

kaizencc
kaizencc commented Jan 22, 2025
View reviewed changes
packages/@aws-cdk-testing/cli-integ/tests/cli-integ-tests/cli.integtest.ts
@@ -363,7 +363,8 @@ integTest('doubly nested stack',
await fixture.cdkDeploy('with-doubly-nested-stack', {
captureStderr: false,
});
}));
}),
);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is just a me fix :) plz don't make me pull it out into a separate PR

@codecov Codecov
Copy link

codecov bot commented Jan 22, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.54%. Comparing base (6a9cbc2) to head (3ca0e9c).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main   #33077   +/-   ##
=======================================
  Coverage   81.54%   81.54%           
=======================================
  Files         226      226           
  Lines       13777    13777           
  Branches     2414     2414           
=======================================
  Hits        11235    11235           
  Misses       2270     2270           
  Partials      272      272
Flag Coverage Δ
suite.unit 81.54% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
packages/aws-cdk 80.94% <ø> (ø)
packages/aws-cdk-lib/core 82.17% <ø> (ø)

@mrgrain mrgrain added the pr/do-not-merge This PR should not be merged at this time. label Jan 23, 2025
@mrgrain
Copy link
Contributor

mrgrain commented Jan 23, 2025

Thanks for the contribution @kaizencc Really appreciate it! Unfortunately I have to block this until a few important PRs on the CLI have been merged. They are moving some files around, so this will be a bit too risky with regards to conflicts. I will keep you posted and/or do the fix up myself.

@mrgrain mrgrain removed the pr/do-not-merge This PR should not be merged at this time. label Jan 23, 2025
@mrgrain
Copy link
Contributor

mrgrain commented Jan 23, 2025

Removed DNM since PR doesn't touch aws-cdk anymore

@mergify Mergify
Copy link
Contributor

mergify bot commented Jan 23, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify Mergify
Copy link
Contributor

mergify bot commented Jan 23, 2025

This pull request has been removed from the queue for the following reason: checks failed.

The merge conditions cannot be satisfied due to failing checks:

You should look at the reason for the failure and decide if the pull request needs to be fixed or if you want to requeue it.

If you want to requeue this pull request, you need to post a comment with the text: @mergifyio requeue

@mergify Mergify
Copy link
Contributor

mergify bot commented Jan 23, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 3ca0e9c
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 1e2c1ae into main Jan 23, 2025
19 of 20 checks passed
@mergify Mergify
Copy link
Contributor

mergify bot commented Jan 23, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot deleted the conroy/eslint-comment-spacing-3 branch January 23, 2025 19:34
@github-actions GitHub Actions
Copy link

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 23, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@GavinZZ GavinZZ GavinZZ approved these changes

@mrgrain mrgrain mrgrain approved these changes

@otaviomacedo otaviomacedo otaviomacedo approved these changes

@aws-cdk-automation aws-cdk-automation aws-cdk-automation left review comments

Assignees
No one assigned
Labels
contribution/core This is a PR that came from AWS. p2 pr-linter/cli-integ-tested Assert that any CLI changes have been integ tested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@kaizencc @mrgrain @aws-cdk-automation @otaviomacedo @GavinZZ