Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(cli): organize code that should only be used by the CLI into a folder #33138

Merged
merged 3 commits into from
Jan 24, 2025

Conversation

mrgrain
Copy link
Contributor

@mrgrain mrgrain commented Jan 24, 2025

Reason for this change

This PR is separating the code that should only be used by the CLI into a specific folder.
It's currently quite hard to reason about the existing api code as its spread across many files and deep subpath imports.
The change deliberately gives up on potential feature reusability of some helpers in order to create locality.

Similar to #33094

Description of changes

Collating existing files and APIs that should only be used by the CLI into a new cli folder.
Updated imports accordingly.
No functional changes.

Describe any new or updated permissions being added

n/a

Description of how you validated changes

exiting tests

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@mrgrain mrgrain requested a review from a team as a code owner January 24, 2025 13:38
@github-actions github-actions bot added the p2 label Jan 24, 2025
@aws-cdk-automation aws-cdk-automation requested a review from a team January 24, 2025 13:39
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Jan 24, 2025
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(This review is outdated)

@mrgrain mrgrain force-pushed the mrgrain/refactor/cli-specfic-code branch from c3a4ea1 to 149afb4 Compare January 24, 2025 13:44
@mrgrain mrgrain force-pushed the mrgrain/refactor/cli-specfic-code branch from 149afb4 to 399631d Compare January 24, 2025 13:49
@mrgrain mrgrain force-pushed the mrgrain/refactor/cli-specfic-code branch from 399631d to c1cfc29 Compare January 24, 2025 14:04
@mrgrain mrgrain force-pushed the mrgrain/refactor/cli-specfic-code branch from c1cfc29 to 99f65a8 Compare January 24, 2025 14:13
Copy link

codecov bot commented Jan 24, 2025

Codecov Report

Attention: Patch coverage is 86.91275% with 39 lines in your changes missing coverage. Please review.

Project coverage is 80.77%. Comparing base (7329068) to head (0073482).

❌ Your patch check has failed because the patch coverage (86.91%) is below the target coverage (95.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #33138      +/-   ##
==========================================
- Coverage   81.57%   80.77%   -0.80%     
==========================================
  Files         227      232       +5     
  Lines       13793    14110     +317     
  Branches     2419     2453      +34     
==========================================
+ Hits        11251    11398     +147     
- Misses       2270     2432     +162     
- Partials      272      280       +8     
Flag Coverage Δ
suite.unit 80.77% <86.91%> (-0.80%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
packages/aws-cdk 79.50% <86.91%> (-1.49%) ⬇️
packages/aws-cdk-lib/core 82.17% <ø> (ø)

@mrgrain mrgrain added the pr-linter/exempt-codecov The PR linter will not require codecov checks to pass label Jan 24, 2025
@mrgrain mrgrain added the pr-linter/cli-integ-tested Assert that any CLI changes have been integ tested label Jan 24, 2025
@aws-cdk-automation aws-cdk-automation dismissed their stale review January 24, 2025 17:40

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@aws-cdk-automation
Copy link
Collaborator

➡️ PR build request submitted to test-main-pipeline ⬅️

A maintainer must now check the pipeline and add the pr-linter/cli-integ-tested label once the pipeline succeeds.

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 0073482
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Copy link
Contributor

mergify bot commented Jan 24, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mrgrain mrgrain merged commit fbb237e into main Jan 24, 2025
13 of 18 checks passed
@mrgrain mrgrain deleted the mrgrain/refactor/cli-specfic-code branch January 24, 2025 19:28
Copy link

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 24, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
contribution/core This is a PR that came from AWS. p2 pr-linter/cli-integ-tested Assert that any CLI changes have been integ tested pr-linter/exempt-codecov The PR linter will not require codecov checks to pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants