-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(cli): organize code that should only be used by the CLI into a folder #33138
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(This review is outdated)
c3a4ea1
to
149afb4
Compare
149afb4
to
399631d
Compare
399631d
to
c1cfc29
Compare
c1cfc29
to
99f65a8
Compare
Codecov ReportAttention: Patch coverage is
❌ Your patch check has failed because the patch coverage (86.91%) is below the target coverage (95.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #33138 +/- ##
==========================================
- Coverage 81.57% 80.77% -0.80%
==========================================
Files 227 232 +5
Lines 13793 14110 +317
Branches 2419 2453 +34
==========================================
+ Hits 11251 11398 +147
- Misses 2270 2432 +162
- Partials 272 280 +8
Flags with carried forward coverage won't be shown. Click here to find out more.
|
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
➡️ PR build request submitted to A maintainer must now check the pipeline and add the |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Comments on closed issues and PRs are hard for our team to see. |
Reason for this change
This PR is separating the code that should only be used by the CLI into a specific folder.
It's currently quite hard to reason about the existing api code as its spread across many files and deep subpath imports.
The change deliberately gives up on potential feature reusability of some helpers in order to create locality.
Similar to #33094
Description of changes
Collating existing files and APIs that should only be used by the CLI into a new
cli
folder.Updated imports accordingly.
No functional changes.
Describe any new or updated permissions being added
n/a
Description of how you validated changes
exiting tests
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license