-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[joysl] Neptune Autoscaling #180
Merged
canavandl
merged 4 commits into
aws:main
from
joysl:feature/Asset-Library-Neptune-Autoscaling
Jan 17, 2024
+366
−160
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,5 @@ | ||
// DO NOT MODIFY THIS FILE MANUALLY BUT DO COMMIT IT. It is generated and used by Rush. | ||
{ | ||
"pnpmShrinkwrapHash": "6ff045f325a4557e2c96b1cf8e6a73cea9638863", | ||
"pnpmShrinkwrapHash": "a91e3cdfb0f70338c98919f90c62b3eb5bfe08c0", | ||
"preferredVersionsHash": "14c05a7722342014cec64c4bef7d9bed0d0b7b7f" | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
60 changes: 60 additions & 0 deletions
60
source/packages/services/assetlibrary/infrastructure/cfn-autoscaling-neptune.yml
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,60 @@ | ||
--- | ||
#----------------------------------------------------------------------------------------------------------------------- | ||
# Copyright Amazon.com Inc. or its affiliates. All Rights Reserved. | ||
# | ||
# Licensed under the Apache License, Version 2.0 (the 'License'). You may not use this file except in compliance | ||
# with the License. A copy of the License is located at | ||
# | ||
# http://www.apache.org/licenses/LICENSE-2.0 | ||
# | ||
# or in the 'license' file accompanying this file. This file is distributed on an 'AS IS' BASIS, WITHOUT WARRANTIES | ||
# OR CONDITIONS OF ANY KIND, express or implied. See the License for the specific language governing permissions | ||
# and limitations under the License. | ||
#----------------------------------------------------------------------------------------------------------------------- | ||
AWSTemplateFormatVersion: '2010-09-09' | ||
Transform: AWS::Serverless-2016-10-31 | ||
|
||
Description: | | ||
CDF Asset Library Service Scaling | ||
================================= | ||
This template provides an example of how to apply auto-scaling to the Asset Library Neptune Cluster. | ||
|
||
Parameters: | ||
MinCapacity: | ||
Description: The minimum value to scale to in response to a scale-in event. | ||
Type: Number | ||
Default: 1 | ||
MaxCapacity: | ||
Description: The maximum value to scale to in response to a scale-out event. | ||
Type: Number | ||
Default: 1 | ||
TargetUtilization: | ||
Description: Target utilization (0 to 90). | ||
Type: Number | ||
Default: 75 | ||
NeptuneClusterID: | ||
Description: This parameter will contain the ClusterID used for Neptune Auto Scaling | ||
Type: String | ||
Default: cluster:test | ||
|
||
Resources: | ||
ScalableTarget: | ||
Type: AWS::ApplicationAutoScaling::ScalableTarget | ||
Properties: | ||
MaxCapacity: !Ref MaxCapacity | ||
MinCapacity: !Ref MinCapacity | ||
ResourceId: !Ref NeptuneClusterID | ||
RoleARN: !Sub arn:aws:iam::${AWS::AccountId}:role/aws-service-role/neptune.application-autoscaling.amazonaws.com/AWSServiceRoleForApplicationAutoScaling_NeptuneCluster | ||
ScalableDimension: neptune:cluster:ReadReplicaCount | ||
ServiceNamespace: neptune | ||
|
||
TargetTrackingScalingPolicy: | ||
Type: AWS::ApplicationAutoScaling::ScalingPolicy | ||
Properties: | ||
PolicyName: utilizationNeptune | ||
PolicyType: TargetTrackingScaling | ||
ScalingTargetId: !Ref ScalableTarget | ||
TargetTrackingScalingPolicyConfiguration: | ||
TargetValue: !Ref TargetUtilization | ||
PredefinedMetricSpecification: | ||
PredefinedMetricType: NeptuneReaderAverageCPUUtilization |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Open question: What's the benefit of having this be a nested stack instead of part of the top-level one?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just decided to follow what was set for Lambda autoscaling which was a nested stack.