Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No mips-unknown-linux-musl support #522

Open
greenfn2233 opened this issue Sep 14, 2024 · 4 comments
Open

No mips-unknown-linux-musl support #522

greenfn2233 opened this issue Sep 14, 2024 · 4 comments
Assignees
@justsmth
Labels
build problem Build failure

Comments

@greenfn2233
Copy link

greenfn2233 commented Sep 14, 2024 •
edited
Loading

Problem:

Host machine: x86_x64_linux_unkown
Trying to compile aws-lc-rs/sys for mips-unknown-linux-musl using cross-rs fails :

The following warnings were emitted during compilation:

warning: [email protected]: CMAKE environment variable set: cmake
warning: [email protected]: Generating bindings - internal bindgen. Platform: mips-unknown-linux-musl

error: failed to run custom build command for `aws-lc-sys v0.21.1`

Caused by:
  process didn't exit successfully: `/target/release/build/aws-lc-sys-cf918696693dee5a/build-script-main` (exit status: 101)
  --- stdout
  cargo:rerun-if-env-changed=AWS_LC_SYS_NO_PREFIX
  cargo:rerun-if-env-changed=AWS_LC_SYS_INTERNAL_BINDGEN
  cargo:rerun-if-env-changed=AWS_LC_SYS_EXTERNAL_BINDGEN
  cargo:rerun-if-env-changed=AWS_LC_SYS_NO_ASM
  cargo:rerun-if-env-changed=AWS_LC_SYS_CFLAGS
  cargo:rerun-if-env-changed=AWS_LC_SYS_PREBUILT_NASM
  cargo:rerun-if-env-changed=AWS_LC_SYS_C_STD
  cargo:rerun-if-env-changed=AWS_LC_SYS_CMAKE_BUILDER
  cargo:rerun-if-env-changed=AWS_LC_SYS_STATIC
  cargo:rerun-if-env-changed=CMAKE
  cargo:rerun-if-env-changed=CMAKE
  cargo:warning=CMAKE environment variable set: cmake
  cargo:warning=Generating bindings - internal bindgen. Platform: mips-unknown-linux-musl
  cargo:rerun-if-env-changed=AWS_LC_SYS_INCLUDES

  --- stderr
  /home//.local/share/cargo/registry/src/index.crates.io-6f17d22bba15001f/aws-lc-sys-0.21.1/aws-lc/include/openssl/target.h:78:2: error: "Unknown target CPU"
  /home//.local/share/cargo/registry/src/index.crates.io-6f17d22bba15001f/aws-lc-sys-0.21.1/aws-lc/include/openssl/bn.h:176:2: error: "Must define either OPENSSL_32_BIT or OPENSSL_64_BIT"
  /home//.local/share/cargo/registry/src/index.crates.io-6f17d22bba15001f/aws-lc-sys-0.21.1/aws-lc/include/openssl/bn.h:234:44: error: unknown type name 'BN_ULONG'
  /home//.local/share/cargo/registry/src/index.crates.io-6f17d22bba15001f/aws-lc-sys-0.21.1/aws-lc/include/openssl/bn.h:332:16: error: unknown type name 'BN_ULONG'
  /home//.local/share/cargo/registry/src/index.crates.io-6f17d22bba15001f/aws-lc-sys-0.21.1/aws-lc/include/openssl/bn.h:405:43: error: unknown type name 'BN_ULONG'
  /home//.local/share/cargo/registry/src/index.crates.io-6f17d22bba15001f/aws-lc-sys-0.21.1/aws-lc/include/openssl/bn.h:418:43: error: unknown type name 'BN_ULONG'
  /home//.local/share/cargo/registry/src/index.crates.io-6f17d22bba15001f/aws-lc-sys-0.21.1/aws-lc/include/openssl/bn.h:427:44: error: unknown type name 'BN_ULONG'
  /home//.local/share/cargo/registry/src/index.crates.io-6f17d22bba15001f/aws-lc-sys-0.21.1/aws-lc/include/openssl/bn.h:445:16: error: unknown type name 'BN_ULONG'
  /home//.local/share/cargo/registry/src/index.crates.io-6f17d22bba15001f/aws-lc-sys-0.21.1/aws-lc/include/openssl/bn.h:445:56: error: unknown type name 'BN_ULONG'
  /home//.local/share/cargo/registry/src/index.crates.io-6f17d22bba15001f/aws-lc-sys-0.21.1/aws-lc/include/openssl/bn.h:462:49: error: unknown type name 'BN_ULONG'
  /home//.local/share/cargo/registry/src/index.crates.io-6f17d22bba15001f/aws-lc-sys-0.21.1/aws-lc/include/openssl/bn.h:476:53: error: unknown type name 'BN_ULONG'
  /home//.local/share/cargo/registry/src/index.crates.io-6f17d22bba15001f/aws-lc-sys-0.21.1/aws-lc/include/openssl/bn.h:485:49: error: unknown type name 'BN_ULONG'
  /home//.local/share/cargo/registry/src/index.crates.io-6f17d22bba15001f/aws-lc-sys-0.21.1/aws-lc/include/openssl/bn.h:544:16: error: unknown type name 'BN_ULONG'
  /home//.local/share/cargo/registry/src/index.crates.io-6f17d22bba15001f/aws-lc-sys-0.21.1/aws-lc/include/openssl/bn.h:544:54: error: unknown type name 'BN_ULONG'
  /home//.local/share/cargo/registry/src/index.crates.io-6f17d22bba15001f/aws-lc-sys-0.21.1/aws-lc/include/openssl/bn.h:662:48: error: unknown type name 'BN_ULONG'
  /home//.local/share/cargo/registry/src/index.crates.io-6f17d22bba15001f/aws-lc-sys-0.21.1/aws-lc/include/openssl/bn.h:975:52: error: unknown type name 'BN_ULONG'
  /home//.local/share/cargo/registry/src/index.crates.io-6f17d22bba15001f/aws-lc-sys-0.21.1/aws-lc/include/openssl/bn.h:1019:3: error: unknown type name 'BN_ULONG'
  /home//.local/share/cargo/registry/src/index.crates.io-6f17d22bba15001f/aws-lc-sys-0.21.1/aws-lc/include/openssl/bn.h:1050:3: error: unknown type name 'BN_ULONG'
  /home//.local/share/cargo/registry/src/index.crates.io-6f17d22bba15001f/aws-lc-sys-0.21.1/aws-lc/include/openssl/bn.h:1053:42: error: unknown type name 'BN_ULONG'
  thread 'main' panicked at /home//.local/share/cargo/registry/src/index.crates.io-6f17d22bba15001f/aws-lc-sys-0.21.1/builder/bindgen.rs:106:10:
  Unable to generate bindings.: ClangDiagnostic("/home//.local/share/cargo/registry/src/index.crates.io-6f17d22bba15001f/aws-lc-sys-0.21.1/aws-lc/include/openssl/target.h:78:2: error: \"Unknown target CPU\"\n/home//.local/share/cargo/registry/src/index.crates.io-6f17d22bba15001f/aws-lc-sys-0.21.1/aws-lc/include/openssl/bn.h:176:2: error: \"Must define either OPENSSL_32_BIT or OPENSSL_64_BIT\"\n/home//.local/share/cargo/registry/src/index.crates.io-6f17d22bba15001f/aws-lc-sys-0.21.1/aws-lc/include/openssl/bn.h:234:44: error: unknown type name 'BN_ULONG'\n/home//.local/share/cargo/registry/src/index.crates.io-6f17d22bba15001f/aws-lc-sys-0.21.1/aws-lc/include/openssl/bn.h:332:16: error: unknown type name 'BN_ULONG'\n/home//.local/share/cargo/registry/src/index.crates.io-6f17d22bba15001f/aws-lc-sys-0.21.1/aws-lc/include/openssl/bn.h:405:43: error: unknown type name 'BN_ULONG'\n/home//.local/share/cargo/registry/src/index.crates.io-6f17d22bba15001f/aws-lc-sys-0.21.1/aws-lc/include/openssl/bn.h:418:43: error: unknown type name 'BN_ULONG'\n/home//.local/share/cargo/registry/src/index.crates.io-6f17d22bba15001f/aws-lc-sys-0.21.1/aws-lc/include/openssl/bn.h:427:44: error: unknown type name 'BN_ULONG'\n/home//.local/share/cargo/registry/src/index.crates.io-6f17d22bba15001f/aws-lc-sys-0.21.1/aws-lc/include/openssl/bn.h:445:16: error: unknown type name 'BN_ULONG'\n/home//.local/share/cargo/registry/src/index.crates.io-6f17d22bba15001f/aws-lc-sys-0.21.1/aws-lc/include/openssl/bn.h:445:56: error: unknown type name 'BN_ULONG'\n/home//.local/share/cargo/registry/src/index.crates.io-6f17d22bba15001f/aws-lc-sys-0.21.1/aws-lc/include/openssl/bn.h:462:49: error: unknown type name 'BN_ULONG'\n/home//.local/share/cargo/registry/src/index.crates.io-6f17d22bba15001f/aws-lc-sys-0.21.1/aws-lc/include/openssl/bn.h:476:53: error: unknown type name 'BN_ULONG'\n/home//.local/share/cargo/registry/src/index.crates.io-6f17d22bba15001f/aws-lc-sys-0.21.1/aws-lc/include/openssl/bn.h:485:49: error: unknown type name 'BN_ULONG'\n/home//.local/share/cargo/registry/src/index.crates.io-6f17d22bba15001f/aws-lc-sys-0.21.1/aws-lc/include/openssl/bn.h:544:16: error: unknown type name 'BN_ULONG'\n/home//.local/share/cargo/registry/src/index.crates.io-6f17d22bba15001f/aws-lc-sys-0.21.1/aws-lc/include/openssl/bn.h:544:54: error: unknown type name 'BN_ULONG'\n/home//.local/share/cargo/registry/src/index.crates.io-6f17d22bba15001f/aws-lc-sys-0.21.1/aws-lc/include/openssl/bn.h:662:48: error: unknown type name 'BN_ULONG'\n/home//.local/share/cargo/registry/src/index.crates.io-6f17d22bba15001f/aws-lc-sys-0.21.1/aws-lc/include/openssl/bn.h:975:52: error: unknown type name 'BN_ULONG'\n/home//.local/share/cargo/registry/src/index.crates.io-6f17d22bba15001f/aws-lc-sys-0.21.1/aws-lc/include/openssl/bn.h:1019:3: error: unknown type name 'BN_ULONG'\n/home//.local/share/cargo/registry/src/index.crates.io-6f17d22bba15001f/aws-lc-sys-0.21.1/aws-lc/include/openssl/bn.h:1050:3: error: unknown type name 'BN_ULONG'\n/home//.local/share/cargo/registry/src/index.crates.io-6f17d22bba15001f/aws-lc-sys-0.21.1/aws-lc/include/openssl/bn.h:1053:42: error: unknown type name 'BN_ULONG'\n")
  note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
warning: build failed, waiting for other jobs to finish...
[cross] warning: rust-std is not available for mips-unknown-linux-musl
[cross] note: you may need to build components for the target via `-Z build-std=<components>` or in your cross configuration specify `target.mips-unknown-linux-musl.build-std`
              the available components are core, std, alloc, and proc_macro

Note: home/{user} redacted from output.
@justinwsmith
Copy link
Contributor

This appears to be due to the __MIPSEL__ macro not being provided by the compiler.(?) You can see the logic that expects it here. Instead it's falling through to here to generate the Unknown target CPU message that you see.

One workaround you could try would be to define these macros via the environment: AWS_LC_SYS_CFLAGS="-D__MIPSEL__". (Note that with cross-rs, its build environment does not automatically pick up variables from the host environment. More information about this is here.)

@justsmth justsmth self-assigned this Sep 16, 2024
@justsmth justsmth added the build problem Build failure label Sep 16, 2024
@justsmth
Copy link
Contributor

justsmth commented Oct 3, 2024 •
edited
Loading

I'm having trouble finding a Rust toolchain I can use for this. (mips-unknown-linux-musl is a Tier 3 platform for Rust.)

Could you provide some guidance on how I can setup the build environment to target this platform?

@humaita-github
Copy link

humaita-github commented Jan 28, 2025 •
edited
Loading

Hi, just stumbled across the same problem. It is basically failing, because there is no CPU defined for MIPS in openssl/target.h.

If you manually add the following lines before #elif defined(__riscv) && __SIZEOF_POINTER__ == 8 in file ~/.local/share/cargo/registry/src/index.crates.io-6f17d22bba15001f/aws-lc-sys-0.21.1/aws-lc/include/openssl/target.h it will build:
#elif defined(__MIPSEB__) && !defined(__LP64__)
#define OPENSSL_32_BIT
#define OPENSSL_MIPS
#define OPENSSL_BIG_ENDIAN

I know, this is not elegant, but it works.

Let me know if you have any thought on how to automate this (instead of manually patching a temporary file).

PS: To build on this environment you need to use rustup default 1.74.0, i.e. before this target became Tier 3.

@justsmth justsmth mentioned this issue Jan 28, 2025
Merged
@justsmth
Copy link
Contributor

Thanks for the information! I posted a PR in for this change upstream: aws/aws-lc#2143

Feel free to comment on it there.

@justsmth justsmth reopened this Jan 28, 2025
justsmth added a commit to aws/aws-lc that referenced this issue Jan 28, 2025
@justsmth
Check for MIPSEB in target.h (#2143)
d15dc5c 
### Issues:
Addresses: 
* aws/aws-lc-rs#522

### Description of changes: 
Setup macros for big-endian MIPS in "target.h"

### Callout
A contributor informs us that the build for `mips-unknown-linux-musl`
succeeds with this change:
aws/aws-lc-rs#522 (comment)

### Testing:
No CI testing for it. 

By submitting this pull request, I confirm that my contribution is made
under the terms of the Apache 2.0 license and the ISC license.
manastasova pushed a commit to manastasova/aws-lc that referenced this issue Jan 30, 2025
@justsmth @manastasova
Check for MIPSEB in target.h (aws#2143)
3b18668 
### Issues:
Addresses: 
* aws/aws-lc-rs#522

### Description of changes: 
Setup macros for big-endian MIPS in "target.h"

### Callout
A contributor informs us that the build for `mips-unknown-linux-musl`
succeeds with this change:
aws/aws-lc-rs#522 (comment)

### Testing:
No CI testing for it. 

By submitting this pull request, I confirm that my contribution is made
under the terms of the Apache 2.0 license and the ISC license.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@justsmth justsmth

Labels
build problem Build failure
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@justinwsmith @humaita-github @justsmth @greenfn2233