Check for MIPSEB in target.h #2143
Merged
+4
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2143 +/- ##
=======================================
Coverage 78.96% 78.96%
=======================================
Files 610 610
Lines 105293 105293
Branches 14919 14920 +1
=======================================
+ Hits 83141 83142 +1
+ Misses 21500 21499 -1
Partials 652 652 ☔ View full report in Codecov by Sentry. |
andrewhop
approved these changes
Jan 28, 2025
smittals2
approved these changes
Jan 28, 2025
manastasova
pushed a commit
to manastasova/aws-lc
that referenced
this pull request
Jan 30, 2025
### Issues: Addresses: * aws/aws-lc-rs#522 ### Description of changes: Setup macros for big-endian MIPS in "target.h" ### Callout A contributor informs us that the build for `mips-unknown-linux-musl` succeeds with this change: aws/aws-lc-rs#522 (comment) ### Testing: No CI testing for it. By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues:
Addresses:
Description of changes:
Setup macros for big-endian MIPS in "target.h"
Callout
A contributor informs us that the build for
mips-unknown-linux-muslsucceeds with this change: aws/aws-lc-rs#522 (comment)Testing:
No CI testing for it.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.