Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DRAFT] unstable API for ML-DSA #690

Draft
wants to merge 8 commits into
base: main
Choose a base branch
from
Draft

Conversation

justsmth
Copy link
Contributor

@justsmth justsmth commented Feb 6, 2025

Issues:

Resolves #ISSUE-NUMBER1
Addresses #ISSUE-NUMBER2

Description of changes:

Describe current behavior and how your code changes that behavior. If there are no issues this pr is resolving, explain why this change is necessary.

Call-outs:

Point out areas that need special attention or support during the review process. Discuss architecture or design changes.

Testing:

How is this change tested (unit tests, fuzz tests, etc.)? Are there any testing steps to be verified by the reviewer?

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.

@justsmth justsmth force-pushed the api-ml-dsa branch 2 times, most recently from d640650 to e6ef3f0 Compare February 10, 2025 22:24
@codecov-commenter
Copy link

codecov-commenter commented Feb 10, 2025

Codecov Report

Attention: Patch coverage is 88.77193% with 64 lines in your changes missing coverage. Please review.

Project coverage is 92.98%. Comparing base (c358484) to head (45c5f33).
Report is 167 commits behind head on main.

Files with missing lines Patch % Lines
aws-lc-rs/src/pqdsa/key_pair.rs 87.56% 3 Missing and 21 partials ⚠️
aws-lc-rs/src/evp_pkey.rs 91.17% 8 Missing and 7 partials ⚠️
aws-lc-rs/src/ed25519.rs 33.33% 4 Missing and 2 partials ⚠️
aws-lc-rs/src/rsa/key.rs 75.00% 2 Missing and 2 partials ⚠️
aws-lc-rs/src/pqdsa/signature.rs 92.68% 0 Missing and 3 partials ⚠️
aws-lc-rs/src/ec/key_pair.rs 75.00% 0 Missing and 2 partials ⚠️
aws-lc-rs/src/pqdsa.rs 98.00% 2 Missing ⚠️
aws-lc-rs/src/rsa/encryption.rs 0.00% 1 Missing and 1 partial ⚠️
aws-lc-rs/src/ec.rs 85.71% 1 Missing ⚠️
aws-lc-rs/src/ec/encoding.rs 66.66% 0 Missing and 1 partial ⚠️
... and 4 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #690      +/-   ##
==========================================
- Coverage   95.80%   92.98%   -2.82%     
==========================================
  Files          61       71      +10     
  Lines        8143     9780    +1637     
  Branches        0     9780    +9780     
==========================================
+ Hits         7801     9094    +1293     
- Misses        342      395      +53     
- Partials        0      291     +291     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants