Add EVP API Support for ED25519ph #2144
Open
+580
−18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skmcgrail
changed the title
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2144 +/- ##
==========================================
+ Coverage 78.97% 79.00% +0.02%
==========================================
Files 611 612 +1
Lines 105500 105724 +224
Branches 14939 14951 +12
==========================================
+ Hits 83317 83523 +206
- Misses 21532 21550 +18
Partials 651 651 ☔ View full report in Codecov by Sentry. |
skmcgrail
changed the title
| EVP_PKEY_ED25519PH, | ||
| {0x2b, 0x65, 0x70}, | ||
| 3, | ||
| pem_str, |
There was a problem hiding this comment.
No, Ed25519ph is not a type of key, its a signing method. That and there is no official OID either that's been adopted. I don't want to arbitrarily introduce a key type / format for a signing method that nobody else supports.
torben-hansen
approved these changes
Jan 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Add support for HashEdDSA (Ed25519ph) to EVP APIs with support for setting the associated signature context. Opting not to expose Ed25519ctx explicitly at this time since there hasn't been an ask for it. Worse case scenario a user desiring it will have access to the low-level APIs where it is available.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.